change: use a new name to customize lua_shared_dict in nginx.conf #5030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous name is easy to mess up with another "lua_shared_dict" configuration. Signed-off-by: spacewander <spacewanderlzx@gmail.com>
tokers
reviewed
Sep 10, 2021
Co-authored-by: Alex Zhang <tokers@apache.org>
tokers
approved these changes
Sep 10, 2021
lilien1010
approved these changes
Sep 13, 2021
| @@ -265,7 +265,7 @@ local config_schema = { | |||
| http = { | |||
| type = "object", | |||
| properties = { | |||
| lua_shared_dicts = { | |||
| custom_lua_shared_dict = { | |||
There was a problem hiding this comment.
will this impact the users upgrade from old version of APISIX?
There was a problem hiding this comment.
lua_shared_dicts is still available now (only a warn message will generate).
moonming
approved these changes
Sep 13, 2021
shuaijinchao
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous name is easy to mess up with another "lua_shared_dict"
configuration.
Signed-off-by: spacewander spacewanderlzx@gmail.com
What this PR does / why we need it:
Pre-submission checklist: