feat: support resolve default value when environment not set #5675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
reviewed
Dec 3, 2021
tzssangglass
approved these changes
Dec 3, 2021
added 2 commits
December 3, 2021 16:48
spacewander
reviewed
Dec 5, 2021
|
BTW, Can you help me to check the ut? I'm confusing about the error log, and it cannot run in my local machine right now. |
|
Solving with #5699 |
tzssangglass
reviewed
Dec 5, 2021
spacewander
approved these changes
Dec 6, 2021
|
@kevinw66 great work 👍 |
tzssangglass
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for review my first pull request for apisix.
And this is my first time use lua. Give me some advices if possible, thanks.
This is about read default value when ENV not set, I think this may helpful when using k8s in different environment and did not want to set so many ENV variable
result:
etcd.host = http://${{ETCD_HOST}}:2379
etcd.host = http://${{ETCD_HOST:123ss}}:2379
etcd.host = http://${{ETCD_HOST:123ss:123aa}}:2379
