-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support reading configuration form xds(mvp) #6614
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
079eefb
feat: support reading configuration form shdict(mvp)
tzssangglass 808bd6e
ci
tzssangglass 5ffd2bf
fix code lint
tzssangglass 815074d
fix code lint
tzssangglass 1ca0254
fix CI
tzssangglass dd1315e
Merge branch 'master' into cgtf
tzssangglass 6fa5a6b
fix code review
tzssangglass 3123d81
replace amesh mock method
tzssangglass ede18da
revert amesh initial function
tzssangglass 5b8726f
fix test cases lib name
tzssangglass d4c8c19
fix CI error
tzssangglass ed3fa36
fix CI error
tzssangglass 87e97c1
fix CI error
tzssangglass 519a823
fix CI error
tzssangglass 3345a31
revert test cases changed in traffic-split
tzssangglass a80954b
Merge branch 'master' of https://github.com/apache/apisix into cgtf
tzssangglass 9a4cb1f
fix code review
tzssangglass 62190bc
fix code review
tzssangglass 82fbcdc
revert config.yaml
tzssangglass b0fa534
resolve code review
tzssangglass 39cca64
rename
tzssangglass add82f7
rename
tzssangglass 7465395
resolve code review
tzssangglass 3123324
fix CI
tzssangglass 8a2a67d
resolve code review
tzssangglass f1fee3b
resolve code review
tzssangglass a9c9ba0
fix CI error
tzssangglass 9b31b34
rename test cases names
tzssangglass 0166d0a
Merge branch 'master' into cgtf
tzssangglass 513c2b3
resolve code review
tzssangglass 57c88d1
resolve code review
tzssangglass 41abb0a
Merge branch 'master' into cgtf
tzssangglass aee463f
Merge branch 'master' into cgtf
tzssangglass File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,120 @@ | ||
-- | ||
-- Licensed to the Apache Software Foundation (ASF) under one or more | ||
-- contributor license agreements. See the NOTICE file distributed with | ||
-- this work for additional information regarding copyright ownership. | ||
-- The ASF licenses this file to You under the Apache License, Version 2.0 | ||
-- (the "License"); you may not use this file except in compliance with | ||
-- the License. You may obtain a copy of the License at | ||
-- | ||
-- http://www.apache.org/licenses/LICENSE-2.0 | ||
-- | ||
-- Unless required by applicable law or agreed to in writing, software | ||
-- distributed under the License is distributed on an "AS IS" BASIS, | ||
-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
-- See the License for the specific language governing permissions and | ||
-- limitations under the License. | ||
-- | ||
|
||
--- Get configuration form ngx.shared.DICT. | ||
-- | ||
-- @module core.config_xds | ||
|
||
local base = require("resty.core.base") | ||
local config_local = require("apisix.core.config_local") | ||
local table = table | ||
local error = error | ||
local is_http = ngx.config.subsystem == "http" | ||
local io = io | ||
local io_open = io.open | ||
local io_close = io.close | ||
local package = package | ||
local new_tab = base.new_tab | ||
local ffi = require ("ffi") | ||
local C = ffi.C | ||
local route_config = ngx.shared["xds-route-config"] | ||
local ngx_re_match = ngx.re.match | ||
local ngx_re_gmatch = ngx.re.gmatch | ||
|
||
local xds_lib_name = "libxds.so" | ||
|
||
|
||
local process | ||
if is_http then | ||
process = require("ngx.process") | ||
end | ||
|
||
|
||
ffi.cdef[[ | ||
extern void initial(void* route_zone_ptr); | ||
]] | ||
|
||
|
||
local _M = { | ||
version = 0.1, | ||
local_conf = config_local.local_conf, | ||
} | ||
|
||
|
||
-- todo: refactor this function in chash.lua and radixtree.lua | ||
local function load_shared_lib(lib_name) | ||
local cpath = package.cpath | ||
local tried_paths = new_tab(32, 0) | ||
local i = 1 | ||
|
||
local iter, err = ngx_re_gmatch(cpath, "[^;]+", "jo") | ||
if not iter then | ||
error("failed to gmatch: " .. err) | ||
end | ||
|
||
while true do | ||
local it = iter() | ||
local fpath | ||
fpath, err = ngx_re_match(it[0], "(.*/)", "jo") | ||
if err then | ||
error("failed to match: " .. err) | ||
end | ||
local spath = fpath[0] .. lib_name | ||
|
||
local f = io_open(spath) | ||
if f ~= nil then | ||
io_close(f) | ||
return ffi.load(spath) | ||
end | ||
tried_paths[i] = spath | ||
i = i + 1 | ||
|
||
if not it then | ||
break | ||
end | ||
end | ||
|
||
return nil, tried_paths | ||
end | ||
|
||
|
||
local function load_libxds(lib_name) | ||
local xdsagent, tried_paths = load_shared_lib(lib_name) | ||
|
||
if not xdsagent then | ||
tried_paths[#tried_paths + 1] = 'tried above paths but can not load ' .. lib_name | ||
error("can not load xds library, tried paths: " .. | ||
table.concat(tried_paths, '\r\n', 1, #tried_paths)) | ||
end | ||
|
||
local route_zone = C.ngx_http_lua_ffi_shdict_udata_to_zone(route_config[1]) | ||
local route_shd_cdata = ffi.cast("void*", route_zone) | ||
xdsagent.initial(route_shd_cdata) | ||
end | ||
|
||
|
||
|
||
function _M.init_worker() | ||
if process.type() == "privileged agent" then | ||
load_libxds(xds_lib_name) | ||
end | ||
|
||
return true | ||
end | ||
|
||
|
||
return _M |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -239,7 +239,7 @@ apisix: | |
_EOC_ | ||
} | ||
|
||
my $lua_deps_path = <<_EOC_; | ||
my $lua_deps_path = $block->lua_deps_path // <<_EOC_; | ||
lua_package_path "$apisix_home/?.lua;$apisix_home/?/init.lua;$apisix_home/deps/share/lua/5.1/?/init.lua;$apisix_home/deps/share/lua/5.1/?.lua;$apisix_home/apisix/?.lua;$apisix_home/t/?.lua;;"; | ||
lua_package_cpath "$apisix_home/?.so;$apisix_home/deps/lib/lua/5.1/?.so;$apisix_home/deps/lib64/lua/5.1/?.so;;"; | ||
_EOC_ | ||
|
@@ -509,6 +509,7 @@ _EOC_ | |
lua_shared_dict ext-plugin 1m; | ||
lua_shared_dict kubernetes 1m; | ||
lua_shared_dict tars 1m; | ||
lua_shared_dict xds-route-config 1m; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we sync the setting in Change There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is enough in the test. |
||
|
||
proxy_ssl_name \$upstream_host; | ||
proxy_ssl_server_name on; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,105 @@ | ||
# | ||
# Licensed to the Apache Software Foundation (ASF) under one or more | ||
# contributor license agreements. See the NOTICE file distributed with | ||
# this work for additional information regarding copyright ownership. | ||
# The ASF licenses this file to You under the Apache License, Version 2.0 | ||
# (the "License"); you may not use this file except in compliance with | ||
# the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
use t::APISIX 'no_plan'; | ||
|
||
use Cwd qw(cwd); | ||
my $apisix_home = $ENV{APISIX_HOME} || cwd(); | ||
|
||
repeat_each(1); | ||
no_long_string(); | ||
no_root_location(); | ||
log_level("info"); | ||
|
||
add_block_preprocessor(sub { | ||
my ($block) = @_; | ||
|
||
if (!$block->request) { | ||
$block->set_value("request", "GET /t"); | ||
} | ||
|
||
if (!$block->no_error_log) { | ||
$block->set_value("no_error_log", "[error]\n[alert]"); | ||
} | ||
|
||
my $lua_deps_path = $block->lua_deps_path // <<_EOC_; | ||
lua_package_path "$apisix_home/?.lua;$apisix_home/?/init.lua;$apisix_home/deps/share/lua/5.1/?/init.lua;$apisix_home/deps/share/lua/5.1/?.lua;$apisix_home/apisix/?.lua;$apisix_home/t/?.lua;;"; | ||
lua_package_cpath "$apisix_home/?.so;$apisix_home/t/xds-library/?.so;$apisix_home/deps/lib/lua/5.1/?.so;$apisix_home/deps/lib64/lua/5.1/?.so;;"; | ||
_EOC_ | ||
|
||
$block->set_value("lua_deps_path", $lua_deps_path); | ||
|
||
my $extra_init_by_lua = <<_EOC_; | ||
-- | ||
local config_xds = require("apisix.core.config_xds") | ||
|
||
local inject = function(mod, name) | ||
local old_f = mod[name] | ||
mod[name] = function (...) | ||
ngx.log(ngx.WARN, "config_xds run ", name) | ||
return { true } | ||
end | ||
end | ||
|
||
inject(config_xds, "new") | ||
|
||
_EOC_ | ||
|
||
$block->set_value("extra_init_by_lua", $extra_init_by_lua); | ||
|
||
if (!$block->yaml_config) { | ||
my $yaml_config = <<_EOC_; | ||
apisix: | ||
node_listen: 1984 | ||
config_center: xds | ||
enable_admin: false | ||
_EOC_ | ||
|
||
$block->set_value("yaml_config", $yaml_config); | ||
} | ||
}); | ||
|
||
run_tests; | ||
|
||
__DATA__ | ||
|
||
=== TEST 1: load xDS library successfully | ||
--- config | ||
location /t { | ||
content_by_lua_block { | ||
ngx.say("ok") | ||
} | ||
} | ||
--- no_error_log eval | ||
qr/can not load xDS library/ | ||
|
||
|
||
|
||
=== TEST 2: read data form shdict that wirted by xDS library | ||
--- config | ||
location /t { | ||
content_by_lua_block { | ||
-- wait for xds library sync data | ||
ngx.sleep(1.5) | ||
local core = require("apisix.core") | ||
local value = ngx.shared["xds-route-config"]:get("/apisix/routes/1") | ||
local route_conf, err = core.json.decode(value) | ||
local json_encode = require("toolkit.json").encode | ||
ngx.say(json_encode(route_conf)) | ||
} | ||
} | ||
--- response_body | ||
{"create_time":1646972532,"id":"1","priority":0,"status":1,"update_time":1647250524,"upstream":{"hash_on":"vars","nodes":[{"host":"127.0.0.1","port":80,"priority":0,"weight":1}],"pass_host":"pass","scheme":"http","type":"roundrobin"},"uri":"/hello"} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to change it in the next PR😅, otherwise it will dismiss the previous approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK