-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update "cors" docs #6877
docs: update "cors" docs #6877
Conversation
Signed-off-by: Navendu Pottekkat <navendupottekkat@gmail.com>
Signed-off-by: Navendu Pottekkat <navendupottekkat@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to submit a PR per plugin, while the changes are similar?
Hi, @spacewander, I just checked all PRs, and each PR has minor changes, which means we could review and merge quickly. Just to make sure, you would prefer the previous PR style? like PR[1]? [1] #6824 |
I will combine multiple PRs into one (one PR a day) from the next PRs. This would be a good middle ground. |
|
||
Create a `Route` or `Service` object and configure `cors` plugin. | ||
You can enable the Plugin on a specific Route or Service: | ||
|
||
```shell | ||
curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For commands that are too long, should we format them? or keep it?
I think formatting long commands helps the user to see all the commands, otherwise he also needs to slide the scroll bar. Maybe we need to do this in all documents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I have kept it as it is on all docs. Maybe we can create a separate issue to ensure better formatting.
Signed-off-by: Navendu Pottekkat <navendupottekkat@gmail.com>
Signed-off-by: Navendu Pottekkat <navendupottekkat@gmail.com>
Signed-off-by: Navendu Pottekkat navendupottekkat@gmail.com
Description
Updates the documentation of the "cors" Plugin.
Child PR of #6734