fix: the client verify flag might not be set #6906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A more suitable way is to reject client TLS handshake directly, just like what Go has done. Fix apache#6896 Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
membphis
reviewed
Apr 22, 2022
membphis
reviewed
Apr 22, 2022
apisix/init.lua
Outdated
| -- always fetch table from the table pool, we don't need a reused api_ctx | ||
| local api_ctx = core.tablepool.fetch("api_ctx", 0, 32) | ||
| ngx_ctx.api_ctx = api_ctx | ||
|
|
||
| if not verify_tls_client(ngx_ctx.api_ctx) then |
membphis
reviewed
Apr 22, 2022
apisix/init.lua
Outdated
| if not api_ctx then | ||
| api_ctx = core.tablepool.fetch("api_ctx", 0, 32) | ||
| ngx_ctx.api_ctx = api_ctx | ||
| end | ||
|
|
||
| if not verify_tls_client(ngx_ctx.api_ctx) then |
|
Anyway to test the fix? |
Not so easy to do it. |
tokers
approved these changes
Apr 22, 2022
membphis
approved these changes
Apr 22, 2022
spacewander
added a commit
to spacewander/incubator-apisix
that referenced
this pull request
May 18, 2022
A more suitable way is to reject the client TLS handshake directly, just like what Go has done. Fix apache#6896 Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander
added a commit
that referenced
this pull request
May 18, 2022
A more suitable way is to reject the client TLS handshake directly, just like what Go has done. Fix #6896 Signed-off-by: spacewander <spacewanderlzx@gmail.com>
tzssangglass
pushed a commit
to tzssangglass/apisix
that referenced
this pull request
May 19, 2022
A more suitable way is to reject the client TLS handshake directly, just like what Go has done. Fix apache#6896 Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander
added a commit
that referenced
this pull request
May 20, 2022
A more suitable way is to reject the client TLS handshake directly, just like what Go has done. Fix #6896 Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Liu-Junlin
pushed a commit
to Liu-Junlin/apisix
that referenced
this pull request
May 20, 2022
A more suitable way is to reject the client TLS handshake directly, just like what Go has done. Fix apache#6896 Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander
added a commit
to spacewander/incubator-apisix
that referenced
this pull request
May 27, 2022
A more suitable way is to reject the client TLS handshake directly, just like what Go has done. Fix apache#6896 Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander
added a commit
that referenced
this pull request
Jun 30, 2022
A more suitable way is to reject the client TLS handshake directly, just like what Go has done. Fix #6896 Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more suitable way is to reject client TLS handshake directly, just
like what Go has done.
Signed-off-by: spacewander spacewanderlzx@gmail.com
Description
Fixes #6896
Checklist