-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update "Metrics" Plugins #7188
Merged
juzhiyuan
merged 8 commits into
apache:master
from
pottekkat:docs/plugin-observability-metrics/6734
Jun 17, 2022
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0099cc4
docs: update "Metrics" Plugins
pottekkat 269654a
Merge branch 'master' into docs/plugin-observability-metrics/6734
pottekkat 3733379
fix lint errors
pottekkat deac384
Merge branch 'docs/plugin-observability-metrics/6734' of https://gith…
pottekkat 60b487e
apply suggestions from review
pottekkat 380dde0
Merge branch 'master' into docs/plugin-observability-metrics/6734
pottekkat fad54b0
update keywords based on suggestions
pottekkat 86ad0ee
Merge branch 'docs/plugin-observability-metrics/6734' of https://gith…
pottekkat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it would be nice to put these into a tabular form. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are following this structure without tables in some other places as well. So, we can keep it as it is now.