Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update admin api English doc #8227

Merged
merged 4 commits into from
Dec 2, 2022
Merged

Conversation

guitu168
Copy link
Contributor

@guitu168 guitu168 commented Nov 1, 2022

Description

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@guitu168 guitu168 marked this pull request as ready for review November 3, 2022 14:51
SylviaBABY
SylviaBABY previously approved these changes Nov 4, 2022
@juzhiyuan
Copy link
Member

@hf400159 also this one

@guitu168
Copy link
Contributor Author

@hf400159 also this one

@juzhiyuan fixed

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Admin API page is too long to read and use 🤣🤣 I suggest separating it into smaller parts in the future.

docs/en/latest/admin-api.md Outdated Show resolved Hide resolved
docs/en/latest/admin-api.md Outdated Show resolved Hide resolved
@guitu168
Copy link
Contributor Author

The Admin API page is too long to read and use 🤣🤣 I suggest separating it into smaller parts in the future.

I will divide the Admin API documentation into several small parts in the next version of the documentation.

Co-authored-by: 琚致远 / Zhiyuan Ju <juzhiyuan@apache.org>
@guitu168 guitu168 requested review from SylviaBABY and juzhiyuan and removed request for SylviaBABY November 30, 2022 01:59
Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM now

@SylviaBABY SylviaBABY merged commit 2f042ee into apache:master Dec 2, 2022
@guitu168 guitu168 deleted the hfenadmin1 branch December 2, 2022 07:30
hongbinhsu added a commit to fitphp/apix that referenced this pull request Dec 4, 2022
* upstream/master: (48 commits)
  fix(ai): remove BUILD_ROUTER event when ai module is unloaded (apache#8184)
  chore: add some comment for make_request_to_vault function (apache#8420)
  docs: update admin api English doc (apache#8227)
  ci: use fixed os version of ubuntu (apache#8438)
  feat: Support store secrets in secrets manager for auth plugin via kms components (apache#8421)
  feat: interact via gRPC in APISIX Admin API (apache#8411)
  fix: last_err can be nil when the reconnection is successful (apache#8377)
  feat: support global data encryption of secret information (apache#8403)
  refactor(env): rename funtion name (apache#8426)
  feat(admin): add kms admin api (apache#8394)
  docs: update consumer and upstream docs (apache#8223)
  ci: add cron job for GM (apache#8398)
  docs: add kms env doc (apache#8419)
  feat: Added log format support in syslog plugin. (apache#8279)
  feat: add vault common components (apache#8412)
  docs: update global-rule/plugin-config/plugin/ docs (apache#8262)
  docs: update consumer-group/router/service/script doc (apache#8332)
  feat: support store secret in env for auth plugin (apache#8390)
  docs: update Upgrade Guide CN version (apache#8392)
  docs: add GM plugin EN doc to make website display normally (apache#8393)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants