Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: APISIX extended variables cannot be used in _meta.filter #8256

Merged
merged 2 commits into from
Nov 7, 2022
Merged

fix: APISIX extended variables cannot be used in _meta.filter #8256

merged 2 commits into from
Nov 7, 2022

Conversation

soulbird
Copy link
Contributor

@soulbird soulbird commented Nov 7, 2022 •
edited
Loading

Description

Fixes #8251

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

bzp2010
bzp2010 approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@bzp2010 bzp2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there is some typo in the PR title. 🤔

@soulbird soulbird changed the title fix: cant't APISIX's built-in variables in meta.filter fix: can't APISIX's built-in variables in meta.filter Nov 7, 2022
@bzp2010 bzp2010 changed the title fix: can't APISIX's built-in variables in meta.filter fix: APISIX extended variables cannot be used in _meta.filter Nov 7, 2022
@spacewander spacewander merged commit 4c533ba into apache:master Nov 7, 2022
spacewander pushed a commit to spacewander/incubator-apisix that referenced this pull request Nov 9, 2022
@soulbird @spacewander
fix: APISIX extended variables cannot be used in _meta.filter (apac…
f8fdcc7 
…he#8256)

Co-authored-by: soulbird <zhaothree@gmail.com>
Fixes apache#8251
spacewander pushed a commit that referenced this pull request Nov 10, 2022
@soulbird @spacewander
fix: APISIX extended variables cannot be used in _meta.filter (#8256)
c020f0e 
Co-authored-by: soulbird <zhaothree@gmail.com>
Fixes #8251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzp2010 bzp2010 bzp2010 approved these changes

@spacewander spacewander spacewander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: built-in variables are not supported in _meta.filter
3 participants
@soulbird @spacewander @bzp2010