Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: proxy-rewrite support config add set and remove header #8336

Merged
merged 22 commits into from
Nov 22, 2022
Merged

feat: proxy-rewrite support config add set and remove header #8336

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
c999d53
feat: proxy-rewrite support add set and remove header
mscb402 Nov 16, 2022
faba9ca
chore: add document
mscb402 Nov 16, 2022
f2ed20f
chore: fix ci error
mscb402 Nov 16, 2022
cbb8b74
chore: fix lint
mscb402 Nov 16, 2022
e3c4d0a
chore: fix document and test case
mscb402 Nov 17, 2022
fee2b02
doc: add priority in document
mscb402 Nov 17, 2022
9496b2a
doc: fix doc lint
mscb402 Nov 17, 2022
5342ee7
chore: rename some function
mscb402 Nov 17, 2022
7c0b85d
chore: change to oneOf
mscb402 Nov 18, 2022
c11d214
chore: change back to anyof
mscb402 Nov 18, 2022
36d3760
chore: fix code.
mscb402 Nov 18, 2022
8d8a03e
chore: format code
mscb402 Nov 18, 2022
b236bc1
chore: clean code
mscb402 Nov 21, 2022
9a82832
chore: fix ci error
mscb402 Nov 21, 2022
07c4104
chore: fix ci error
mscb402 Nov 21, 2022
d3973dd
fix: ci error
mscb402 Nov 21, 2022
4f684db
doc: change doc
mscb402 Nov 21, 2022
84a06d6
Update docs/en/latest/plugins/proxy-rewrite.md
mscb402 Nov 21, 2022
3c2fb83
chore: format code style
mscb402 Nov 21, 2022
05daec5
chore: fix test style
mscb402 Nov 21, 2022
6042fe9
chore: remove line
mscb402 Nov 21, 2022
ab385e4
chore: change antOf to oneOf
mscb402 Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apisix/plugins/proxy-rewrite.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,8 @@ local function check_set_headers(headers)
if #field == 0 then
return false, 'invalid field length in header'
end

core.log.info("header field: ", field)
tokers marked this conversation as resolved.
Show resolved Hide resolved
if not core.utils.validate_header_field(field) then
return false, 'invalid field character in header'
end
Expand Down
16 changes: 11 additions & 5 deletions t/plugin/proxy-rewrite3.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,8 @@ X-Forwarded-Host: test.com
[error]


=== TEST 14: try config header: add, set, remove

=== TEST 14: set route add test
--- config
location /t {
content_by_lua_block {
Expand Down Expand Up @@ -381,7 +382,8 @@ passed
[error]


=== TEST 15: test add exist header in muti-header is working

=== TEST 15: add exist header in muti-header
--- request
GET /echo HTTP/1.1
--- more_headers
Expand All @@ -393,7 +395,8 @@ test: sssss, bbb, 123
[error]


=== TEST 16: test add header to exist header is working

=== TEST 16: add header to exist header
--- request
GET /echo HTTP/1.1
--- more_headers
Expand All @@ -404,7 +407,8 @@ test: sssss, 123
[error]


=== TEST 17: test remove header

=== TEST 17: remove header
--- request
GET /echo HTTP/1.1
--- more_headers
Expand All @@ -415,7 +419,9 @@ hello:
[error]


=== TEST 18: test add header success

=
== TEST 18: remove header success
--- request
GET /echo HTTP/1.1
--- response_headers
Expand Down