feat: consumer-restriction plugin support consumer_group_id type #8567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starsz
previously approved these changes
Dec 26, 2022
spacewander
reviewed
Dec 26, 2022
t/plugin/consumer-restriction.t
Outdated
|
|
||
|
|
||
|
|
||
| === TEST 54: create consumer group(group1) |
There was a problem hiding this comment.
Could you move the new tests to a new file?
When the test file is too large, for example > 800 lines, you should split it to a new file. Please take a look at t/plugin/limit-conn.t and t/plugin/limit-conn2.t.
https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#check-code-style-and-test-case-style
ronething
requested review from
spacewander and
starsz
and removed request for
spacewander and
starsz
starsz
approved these changes
Dec 27, 2022
spacewander
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8563
consumer-restriction plugin add
consumer_group_idtypeChecklist