refactor(admin): stream_routes/upstreams/protos/services/global_rules/consumer_groups/plugin_configs #8661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An-DJ
changed the title
An-DJ
changed the title
An-DJ
changed the title
An-DJ
changed the title
spacewander
reviewed
Jan 12, 2023
apisix/admin/consumer_group.lua
Outdated
|
|
||
| utils.fix_count(res.body, id) | ||
| return res.status, res.body | ||
| return need_id and id or true |
There was a problem hiding this comment.
Look like we can move this line to resource.lua?
apisix/admin/routes.lua
Outdated
| @@ -143,5 +143,6 @@ return resource.new({ | |||
| name = "routes", | |||
| kind = "route", | |||
| schema = core.schema.route, | |||
| checker = check_conf | |||
| checker = check_conf, | |||
| unsupported_methods = {} | |||
There was a problem hiding this comment.
We can leave this nil as this resource doesn't have unsupported methods.
apisix/admin/services.lua
Outdated
| kind = "service", | ||
| schema = core.schema.service, | ||
| checker = check_conf, | ||
| unsupported_methods = {}, |
spacewander
reviewed
Jan 16, 2023
apisix/admin/resource.lua
Outdated
| return self.checker(id, conf, need_id, self.schema) | ||
| local ok, err = self.checker(id, conf, need_id, self.schema) | ||
|
|
||
| if err then |
There was a problem hiding this comment.
Code style, please use if not ok then
spacewander
previously approved these changes
Jan 17, 2023
soulbird
reviewed
Jan 17, 2023
| @@ -199,7 +199,17 @@ local function run() | |||
| end | |||
|
|
|||
| local code, data | |||
| if seg_res == "routes" then | |||
| local refactored_resources = { | |||
There was a problem hiding this comment.
directly named as resources?
There was a problem hiding this comment.
There has been a global variable named resources already. 😭 (https://github.com/apache/apisix/blob/master/apisix/admin/init.lua#L46)
Maybe we can rename that variable after all resources are refactored.
soulbird
reviewed
Jan 17, 2023
apisix/admin/resource.lua
Outdated
| end | ||
|
|
||
|
|
||
| function _M:get(id) | ||
| if self.unsupported_methods and core.table.array_find(self.unsupported_methods, "get") then |
There was a problem hiding this comment.
Is it enough to use if core.table.array_find(self.unsupported_methods, "get") then ?
soulbird
approved these changes
Jan 30, 2023
spacewander
approved these changes
Jan 31, 2023
hongbinhsu
added a commit
to fitphp/apix
that referenced
this pull request
Feb 3, 2023
* upstream/master: feat(elasticsearch-logger): support multi elasticsearch endpoints (apache#8604) chore: use operator # instead of string.len (apache#8751) chore: hi 2023 (apache#8748) refactor(admin): stream_routes/upstreams/protos/services/global_rules/consumer_groups/plugin_configs (apache#8661) feat: support send error-log to kafka brokers (apache#8693) chore: upgrade `casbin` to `1.41.5` (apache#8744)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8569
Checklist