-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: traffic-split plugin support https #9115
Conversation
…fy test case and use ops enable_ipv6
Hi @TenYearsIn, test cases are needed and please make the ci pass |
The Test case (traffic-split2.t) 11 seems that there was some problem, I used the original code to test it, but it still fails |
Without your modification, I can also run the test case through. |
@TenYearsIn, I can add test cases here if you add me as a collaborator in your apisix forked repository. |
Let me try again. if not. do so @shreemaan-abhishek |
@TenYearsIn, please provide access to me to your forked repository. |
@shreemaan-abhishek done |
This reverts commit 8f9ceb2.
|
||
|
||
|
||
=== TEST 21: use upstream with https scheme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test case can pass without your pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like using upstream_id
supports https but using real upstream is not supported, I have pushed my changes now, please review.
Description
Fixes #8996
Checklist