feat: support store route's cert in secrets manager #9247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingluo
previously approved these changes
Apr 6, 2023
added 2 commits
April 11, 2023 15:36
|
please make ci pass |
monkeyDluffy6017
approved these changes
Apr 12, 2023
kingluo
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of #8319
Support for storing certificates on routers through Secret Manager.
When using this function to configure the certificate, we only verify the validity of the certificate when the certificate is used on the DP side. This is done to avoid the problem that the CP side may not be able to access the backend Secret Manager Service.
Checklist