Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: batch-requests: read trailer headers if exist #9289

Merged
merged 2 commits into from
Apr 14, 2023
Merged

fix: batch-requests: read trailer headers if exist #9289

merged 2 commits into from
Apr 14, 2023

Conversation

kingluo
Copy link
Contributor

@kingluo kingluo commented Apr 12, 2023

Description

batch-requests: read trailer headers if exist, especially for grpc response.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@kingluo kingluo marked this pull request as ready for review April 12, 2023 03:52
soulbird
soulbird previously approved these changes Apr 12, 2023
View reviewed changes
Neilblaze
Neilblaze previously approved these changes Apr 12, 2023
View reviewed changes
@kingluo kingluo dismissed stale reviews from Neilblaze and soulbird via 4df5a6b April 14, 2023 03:39
@monkeyDluffy6017 monkeyDluffy6017 merged commit 03481e3 into apache:master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soulbird soulbird soulbird approved these changes

@monkeyDluffy6017 monkeyDluffy6017 monkeyDluffy6017 approved these changes

@Neilblaze Neilblaze Neilblaze left review comments

@leslie-tsang leslie-tsang Awaiting requested review from leslie-tsang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kingluo @monkeyDluffy6017 @soulbird @Neilblaze