fix: proxy-rewrite should set ngx.var.uri #9309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingluo
force-pushed
the
proxy-rewrite-set-uri
branch
from
37a4b94
to
4f4d0dd
Compare
kingluo
commented
Apr 14, 2023
| @@ -317,6 +318,8 @@ function _M.rewrite(conf, ctx) | |||
| upstream_uri = core.utils.uri_safe_encode(upstream_uri) | |||
| end | |||
|
|
|||
| req_set_uri(upstream_uri) | |||
There was a problem hiding this comment.
Note that we don't need to set uri when use_real_request_uri_unsafe is true, because in that case, the upstream_uri is supposed to take precedence.
soulbird
approved these changes
Apr 17, 2023
leslie-tsang
approved these changes
Apr 17, 2023
Neilblaze
approved these changes
Apr 19, 2023
monkeyDluffy6017
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Besides custom
upstream_urivar, it should setngx.var.urito keep compatible.Checklist