Skip to content

Commit

Permalink
ci: disallow pings in PR body text (#1798)
Browse files Browse the repository at this point in the history
Fixes #1739.
  • Loading branch information
lidavidm authored Apr 30, 2024
1 parent 8686e6c commit 02aecca
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions .github/workflows/dev_pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,3 +57,11 @@ jobs:
PR_TITLE: ${{ github.event.pull_request.title }}
run: |
python .github/workflows/dev_pr/title_check.py $(pwd)/pr_checkout "$PR_TITLE"
# Pings make it into the commit message where they annoy the user every
# time the commit gets pushed somewhere
- name: Check PR body for pings
env:
PR_BODY: ${{ github.event.pull_request.body }}
run: |
[[ "${PR_BODY}" =~ @[a-zA-Z0-9]+ ]] && exit 1 || true

0 comments on commit 02aecca

Please sign in to comment.