test(c/driver/snowflake): fix timestamp tests (#911)

Fixes #903.
apache · Jul 18, 2023 · 6e380c0 · 6e380c0
1 parent 78d44ac
commit 6e380c0
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 4 deletions.
diff --git a/c/driver/snowflake/snowflake_test.cc b/c/driver/snowflake/snowflake_test.cc
@@ -178,6 +178,28 @@ class SnowflakeStatementTest : public ::testing::Test,
   }
 
  protected:
+  void ValidateIngestedTemporalData(struct ArrowArrayView* values,
+                                    enum ArrowTimeUnit unit,
+                                    const char* timezone) override {
+    std::vector<std::optional<int64_t>> expected;
+    switch (unit) {
+      case NANOARROW_TIME_UNIT_SECOND:
+        expected = {std::nullopt, -42, 0, 42};
+        break;
+      case NANOARROW_TIME_UNIT_MILLI:
+        expected = {std::nullopt, -42000, 0, 42000};
+        break;
+      case NANOARROW_TIME_UNIT_MICRO:
+        expected = {std::nullopt, -42, 0, 42};
+        break;
+      case NANOARROW_TIME_UNIT_NANO:
+        expected = {std::nullopt, -42, 0, 42};
+        break;
+    }
+    ASSERT_NO_FATAL_FAILURE(
+        adbc_validation::CompareArray<std::int64_t>(values, expected));
+  }
+
   SnowflakeQuirks quirks_;
 };
 ADBCV_TEST_STATEMENT(SnowflakeStatementTest)
diff --git a/c/validation/adbc_validation.cc b/c/validation/adbc_validation.cc
@@ -1172,23 +1172,23 @@ void StatementTest::ValidateIngestedTemporalData(struct ArrowArrayView* values,
 
 void StatementTest::TestSqlIngestTimestamp() {
   ASSERT_NO_FATAL_FAILURE(TestSqlIngestTemporalType<NANOARROW_TIME_UNIT_SECOND>(nullptr));
-  ASSERT_NO_FATAL_FAILURE(TestSqlIngestTemporalType<NANOARROW_TIME_UNIT_MICRO>(nullptr));
   ASSERT_NO_FATAL_FAILURE(TestSqlIngestTemporalType<NANOARROW_TIME_UNIT_MILLI>(nullptr));
+  ASSERT_NO_FATAL_FAILURE(TestSqlIngestTemporalType<NANOARROW_TIME_UNIT_MICRO>(nullptr));
   ASSERT_NO_FATAL_FAILURE(TestSqlIngestTemporalType<NANOARROW_TIME_UNIT_NANO>(nullptr));
 }
 
 void StatementTest::TestSqlIngestTimestampTz() {
   ASSERT_NO_FATAL_FAILURE(TestSqlIngestTemporalType<NANOARROW_TIME_UNIT_SECOND>("UTC"));
-  ASSERT_NO_FATAL_FAILURE(TestSqlIngestTemporalType<NANOARROW_TIME_UNIT_MICRO>("UTC"));
   ASSERT_NO_FATAL_FAILURE(TestSqlIngestTemporalType<NANOARROW_TIME_UNIT_MILLI>("UTC"));
+  ASSERT_NO_FATAL_FAILURE(TestSqlIngestTemporalType<NANOARROW_TIME_UNIT_MICRO>("UTC"));
   ASSERT_NO_FATAL_FAILURE(TestSqlIngestTemporalType<NANOARROW_TIME_UNIT_NANO>("UTC"));
 
   ASSERT_NO_FATAL_FAILURE(
       TestSqlIngestTemporalType<NANOARROW_TIME_UNIT_SECOND>("America/Los_Angeles"));
-  ASSERT_NO_FATAL_FAILURE(
-      TestSqlIngestTemporalType<NANOARROW_TIME_UNIT_MICRO>("America/Los_Angeles"));
   ASSERT_NO_FATAL_FAILURE(
       TestSqlIngestTemporalType<NANOARROW_TIME_UNIT_MILLI>("America/Los_Angeles"));
+  ASSERT_NO_FATAL_FAILURE(
+      TestSqlIngestTemporalType<NANOARROW_TIME_UNIT_MICRO>("America/Los_Angeles"));
   ASSERT_NO_FATAL_FAILURE(
       TestSqlIngestTemporalType<NANOARROW_TIME_UNIT_NANO>("America/Los_Angeles"));
 }