Skip to content

Commit

Permalink
remove unneeded code
Browse files Browse the repository at this point in the history
  • Loading branch information
WillAyd committed Jul 12, 2023
1 parent d73e3a4 commit b2afd40
Showing 1 changed file with 0 additions and 92 deletions.
92 changes: 0 additions & 92 deletions c/driver/sqlite/sqlite_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -224,98 +224,6 @@ class SqliteStatementTest : public ::testing::Test,
ASSERT_NO_FATAL_FAILURE(adbc_validation::CompareArray<std::string>(values, expected));
}

void TestSqlIngestTemporalType(enum ArrowTimeUnit unit, const char* timezone) {
if (!quirks()->supports_bulk_ingest()) {
GTEST_SKIP();
}

ASSERT_THAT(quirks()->DropTable(&connection, "bulk_ingest", &error),
adbc_validation::IsOkStatus(&error));

adbc_validation::Handle<struct ArrowSchema> schema;
adbc_validation::Handle<struct ArrowArray> array;
struct ArrowError na_error;
const std::vector<std::optional<int64_t>> values = {std::nullopt, -42, 0, 42};
const ArrowType type = NANOARROW_TYPE_TIMESTAMP;

// much of this code is shared with TestSqlIngestType with minor
// changes to allow for various time units to be tested
ArrowSchemaInit(&schema.value);
ArrowSchemaSetTypeStruct(&schema.value, 1);
ArrowSchemaSetTypeDateTime(schema->children[0], type, unit, timezone);
ArrowSchemaSetName(schema->children[0], "col");
ASSERT_THAT(adbc_validation::MakeBatch<int64_t>(&schema.value, &array.value,
&na_error, values),
adbc_validation::IsOkErrno());

ASSERT_THAT(AdbcStatementNew(&connection, &statement, &error),
adbc_validation::IsOkStatus(&error));
ASSERT_THAT(AdbcStatementSetOption(&statement, ADBC_INGEST_OPTION_TARGET_TABLE,
"bulk_ingest", &error),
adbc_validation::IsOkStatus(&error));
ASSERT_THAT(AdbcStatementBind(&statement, &array.value, &schema.value, &error),
adbc_validation::IsOkStatus(&error));

int64_t rows_affected = 0;
ASSERT_THAT(AdbcStatementExecuteQuery(&statement, nullptr, &rows_affected, &error),
adbc_validation::IsOkStatus(&error));
ASSERT_THAT(rows_affected,
::testing::AnyOf(::testing::Eq(values.size()), ::testing::Eq(-1)));

ASSERT_THAT(AdbcStatementSetSqlQuery(
&statement,
"SELECT * FROM bulk_ingest ORDER BY \"col\" ASC NULLS FIRST", &error),
adbc_validation::IsOkStatus(&error));
{
adbc_validation::StreamReader reader;
ASSERT_THAT(AdbcStatementExecuteQuery(&statement, &reader.stream.value,
&reader.rows_affected, &error),
adbc_validation::IsOkStatus(&error));
ASSERT_THAT(reader.rows_affected,
::testing::AnyOf(::testing::Eq(values.size()), ::testing::Eq(-1)));

ASSERT_NO_FATAL_FAILURE(reader.GetSchema());

ArrowType round_trip_type = quirks()->IngestSelectRoundTripType(type);
ASSERT_NO_FATAL_FAILURE(adbc_validation::CompareSchema(
&reader.schema.value, {{"col", round_trip_type, /*NULLABLE=*/true}}));

ASSERT_NO_FATAL_FAILURE(reader.Next());
ASSERT_NE(nullptr, reader.array->release);
ASSERT_EQ(values.size(), reader.array->length);
ASSERT_EQ(1, reader.array->n_children);

std::vector<std::optional<std::string>> expected;
switch (unit) {
case (NANOARROW_TIME_UNIT_SECOND):
expected.insert(expected.end(), {std::nullopt, "1969-12-31T23:59:18",
"1970-01-01T00:00:00", "1970-01-01T00:00:42"});
break;
case (NANOARROW_TIME_UNIT_MILLI):
expected.insert(expected.end(),
{std::nullopt, "1969-12-31T23:59:59.958",
"1970-01-01T00:00:00.000", "1970-01-01T00:00:00.042"});
break;
case (NANOARROW_TIME_UNIT_MICRO):
expected.insert(expected.end(),
{std::nullopt, "1969-12-31T23:59:59.999958",
"1970-01-01T00:00:00.000000", "1970-01-01T00:00:00.000042"});
break;
case (NANOARROW_TIME_UNIT_NANO):
expected.insert(expected.end(), {std::nullopt, "1969-12-31T23:59:59.999999958",
"1970-01-01T00:00:00.000000000",
"1970-01-01T00:00:00.000000042"});
break;
}
ASSERT_NO_FATAL_FAILURE(adbc_validation::CompareArray<std::string>(
reader.array_view->children[0], expected));
ASSERT_NO_FATAL_FAILURE(reader.Next());
ASSERT_EQ(nullptr, reader.array->release);
}

ASSERT_THAT(AdbcStatementRelease(&statement, &error),
adbc_validation::IsOkStatus(&error));
}
SqliteQuirks quirks_;
};
ADBCV_TEST_STATEMENT(SqliteStatementTest)
Expand Down

0 comments on commit b2afd40

Please sign in to comment.