Skip to content

Commit

Permalink
feat(rust/driver/datafusion): remove unnecessary dependency on arrow
Browse files Browse the repository at this point in the history
  • Loading branch information
tokoko committed Oct 22, 2024
1 parent 73d9c09 commit c48dcee
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 6 deletions.
3 changes: 2 additions & 1 deletion rust/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rust/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ categories = ["database"]

[workspace.dependencies]
adbc_core = { path = "./core" }
arrow = { version = "53.1.0", default-features = false }
arrow-array = { version = "53.1.0", default-features = false, features = [
"ffi",
] }
arrow-buffer = { version = "53.1.0", default-features = false }
arrow-schema = { version = "53.1.0", default-features = false }
arrow-select = { version = "53.1.0", default-features = false }
arrow-cast = { version = "53.1.0", default-features = false }
5 changes: 4 additions & 1 deletion rust/drivers/datafusion/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ license = { workspace = true }

[dependencies]
adbc_core = { path = "../../core" }
arrow.workspace = true
arrow-array.workspace = true
arrow-buffer.workspace = true
arrow-schema.workspace = true
Expand All @@ -34,5 +33,9 @@ datafusion-substrait = "42.0.0"
tokio = { version = "1.0", features = ["rt-multi-thread"] }
prost = "0.13.3"

[dev-dependencies]
arrow-select.workspace = true
arrow-cast.workspace = true

[lib]
crate-type = ["lib", "cdylib"]
2 changes: 1 addition & 1 deletion rust/drivers/datafusion/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
use adbc_core::driver_manager::ManagedDriver;
use adbc_core::options::AdbcVersion;
use adbc_core::{Connection, Database, Driver, Statement};
use arrow::util::pretty::print_batches;
use arrow_cast::pretty::print_batches;
use arrow_array::RecordBatch;
fn main() {
Expand Down
2 changes: 1 addition & 1 deletion rust/drivers/datafusion/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ use std::vec::IntoIter;
use std::{collections::HashMap, fmt::Debug};
use tokio::runtime::Runtime;

use arrow::array::{
use arrow_array::builder::{
BooleanBuilder, Int32Builder, Int64Builder, ListBuilder, MapBuilder, MapFieldNames,
StringBuilder, UInt32Builder,
};
Expand Down
2 changes: 1 addition & 1 deletion rust/drivers/datafusion/tests/test_datafusion.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ use arrow_array::RecordBatch;
use datafusion::prelude::*;

use adbc_core::options::AdbcVersion;
use arrow::compute::concat_batches;
use arrow_select::concat::concat_batches;
use datafusion_substrait::logical_plan::producer::to_substrait_plan;
use datafusion_substrait::substrait::proto::Plan;
use prost::Message;
Expand Down

0 comments on commit c48dcee

Please sign in to comment.