Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add recipe for adbc_prepare and low-level bindings #2097

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

lidavidm
Copy link
Member

Relates to #2040.

@lidavidm lidavidm changed the title docs: add recipe for adbc_prepare docs: add recipe for adbc_prepare and low-level bindings Aug 23, 2024
@lidavidm lidavidm marked this pull request as ready for review August 23, 2024 04:05
@github-actions github-actions bot added this to the ADBC Libraries 15 milestone Aug 23, 2024
@lidavidm lidavidm merged commit 262e066 into apache:main Aug 24, 2024
25 of 28 checks passed
@lidavidm lidavidm deleted the minor-docs branch August 24, 2024 01:29
#: (other drivers, like the PostgreSQL driver, may know).
assert rowcount == -1
#: We can use the PyArrow APIs to read the result.
reader = pyarrow.RecordBatchReader._import_from_c_capsule(handle.__arrow_c_stream__())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably recommend using pyarrow.RecordBatchReader.from_stream(handle) instead

lidavidm pushed a commit that referenced this pull request Aug 27, 2024
Small follow-up on #2097

This method is available starting from pyarrow 15.0, only one release
after introduction of the general protocol, so I think it should be fine
to just use that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants