Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust): implement database/connection constructors without options #2242

Merged
merged 1 commit into from
Oct 12, 2024
Merged

fix(rust): implement database/connection constructors without options #2242

merged 1 commit into from
Oct 12, 2024

Conversation

mbrobbel
Copy link
Contributor

Fixes #2241.

@github-actions github-actions bot added this to the ADBC Libraries 15 milestone Oct 10, 2024
paleolimbot
paleolimbot approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Rust is not great but I looked this over from a framework standpoint and it seems reasonable!

@lidavidm
Copy link
Member

Hmm, I'll take a look at the docs failure

@lidavidm
Copy link
Member

If you rebase, hopefully CI should be fixed

@lidavidm lidavidm merged commit cd24bc0 into apache:main Oct 12, 2024
29 checks passed
@mbrobbel mbrobbel deleted the rust/with_opts branch October 12, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

@paleolimbot paleolimbot paleolimbot approved these changes

@wjones127 wjones127 Awaiting requested review from wjones127 wjones127 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 15
Development

Successfully merging this pull request may close these issues.

Rust: constructors w/o opts are ignored
3 participants
@mbrobbel @lidavidm @paleolimbot