fix(csharp/src/Drivers/Apache): remove interleaved async look-ahead code #2273
+4
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birschick-bq
requested review from
lidavidm and
CurtHagenlocher
as code owners
birschick-bq
commented
Oct 22, 2024
| @@ -114,7 +114,7 @@ public void CanExecuteUpdate() | |||
| for (int i = 0; i < queries.Length; i++) | |||
| { | |||
| string query = queries[i]; | |||
| AdbcStatement statement = adbcConnection.CreateStatement(); | |||
| using AdbcStatement statement = adbcConnection.CreateStatement(); | |||
There was a problem hiding this comment.
This helps to exposes the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attempt to use “look-ahead” buffering in the HiveServer2Reader is not supported by the Thrift library. The issue is that the Thrift library uses a shared buffer on the Client/Protocol/Transport object -so interleaving Fetch and ExecuteStatement will fail because the buffer will get closed unexpectedly.