-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(go/adbc/driver/snowflake): Implement concurrency limit #974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for formal config parameters
@lidavidm Do you think it makes sense for the concurrency to be a driver/connection level config param or should it be a statement level config param alongside the queue size? |
Statement level seems most appropriate, though you could inherit it from a connection level parameter for convenience |
In order to improve the performance of the ADBC Snowflake driver, particularly for larger size result sets, we should limit the concurrent connections we make the snowflake during the prefetching in order to avoid excessive blocking / throttling.