perf(go/adbc/driver/snowflake): Implement concurrency limit #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
reviewed
Aug 9, 2023
cpcloud
reviewed
Aug 9, 2023
cpcloud
reviewed
Aug 9, 2023
lidavidm
requested changes
Aug 9, 2023
|
@lidavidm Do you think it makes sense for the concurrency to be a driver/connection level config param or should it be a statement level config param alongside the queue size? |
|
Statement level seems most appropriate, though you could inherit it from a connection level parameter for convenience |
lidavidm
reviewed
Aug 9, 2023
lidavidm
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to improve the performance of the ADBC Snowflake driver, particularly for larger size result sets, we should limit the concurrent connections we make the snowflake during the prefetching in order to avoid excessive blocking / throttling.