Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go/adbc/driver/flightsql): Have GetTableSchema check for table name match instead of the first schema it receives #980

Merged
merged 5 commits into from
Aug 22, 2023

Conversation

ywc88
Copy link
Collaborator

@ywc88 ywc88 commented Aug 16, 2023

Fixes #934.

@ywc88 ywc88 marked this pull request as ready for review August 21, 2023 21:33
@ywc88 ywc88 requested a review from zeroshade as a code owner August 21, 2023 21:33
Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit pick and then I agree with @lidavidm's comment https://github.com/apache/arrow-adbc/pull/980/files#r1301629823

@lidavidm
Copy link
Member

BTW @zeroshade, one thing I noticed while debugging this PR:

https://github.com/apache/arrow/blob/702e9cae138e8d372643e3545375d8fc4c6212a2/go/arrow/flight/flightsql/server.go#L832-L842

	for chunk := range cc {
		if chunk.Err != nil {
			return chunk.Err
		}

		wr.SetFlightDescriptor(chunk.Desc)
		if err = wr.WriteWithAppMetadata(chunk.Data, chunk.AppMetadata); err != nil {
			return err
		}
		chunk.Data.Release()
	}

Shouldn't we release chunk.Data in both branches of the if?

@lidavidm lidavidm added this to the ADBC Libraries 0.6.0 milestone Aug 22, 2023
@lidavidm lidavidm merged commit ddbfaec into apache:main Aug 22, 2023
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go/adbc/driver/flightsql: GetTableSchema needs to check for an exact match
3 participants