feat(r): Add adbc_simulate_dbi() S3 generic
#982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paleolimbot
changed the title
adbc_simulate_dbi() S3 generic
krlmlr
reviewed
Aug 31, 2023
| adbc_simulate_dbi.default <- function(connection, method = NULL, ...) { | ||
| vendor_name <- tryCatch({ | ||
| # 0L == ADBC_INFO_VENDOR_NAME | ||
| with_adbc(info <- adbc_connection_get_info(connection, 0L), { |
There was a problem hiding this comment.
Should there be a local_adbc() ?
| # under the License. | ||
|
|
||
| #' Simulate an equivalent DBI connection | ||
| #' |
There was a problem hiding this comment.
Should we add details on how to use it here, or in a separate vignette?
|
Closing in favour of implementing the quote literal + quote string generics directly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an S3 generic that dispatches on an
adbc_connectionor subclass namedadbc_simulate_dbi(), inspired bydbplyr::simulate_dbi(). This is primarily to help wrappers like adbi and/or dbplyr integrate ADBC drivers into the R database ecosystem. Thanks to @lidavidm for the idea of using the vendor code fromadbc_connection_get_info(): this allows something like the FlightSQL driver to wrap a SQLite database and still get a basic level of integration into the R database ecosystem.An early version of this PR also provided dbplyr wrappers; that dispatched on the simulated DBI connection however, I think that is outside the scope of the adbcdrivermanager (it would be better provided by adbi, which will be the package that provides the necessary wrappers around things like
DBI::dbExecute()).@krlmlr do you think this will provide enough information to be useful (while not getting too deeply into the SQL generation game)?