Remove non idiomatic DataFusionError::into_arrow_external_error in favor of From conversion
#1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jan 22, 2022
| @@ -331,8 +331,7 @@ fn build_batch( | |||
| let scalar = ScalarValue::try_from_array(arr, left_index)?; | |||
| Ok(scalar.to_array_of_size(batch.num_rows())) | |||
| }) | |||
| .collect::<Result<Vec<_>>>() | |||
| .map_err(|x| x.into_arrow_external_error())?; | |||
| .collect::<Result<Vec<_>>>()?; | |||
There was a problem hiding this comment.
this is a pretty good exemplar of how this change makes the DataFusion codebase less confusing
|
We can probably remove any instances of code like as well 🤔 |
alamb
force-pushed
the
alamb/error-cleanup2
branch
from
7356b54
to
342673b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1643, so draft until that is mergedWhich issue does this PR close?
closes #1644
Rationale for this change
The way to convert
DataFusionErrorinto anArrowErroris confusing for Rust programmers coming to the DataFusion codebase and makes our codebase a bit of a messThey typically expect a
impl From<..>conversion traitWhat changes are included in this PR?
DataFusionError::into_arrow_external_errorFromimpl insteadAre there any user-facing changes?
Nicer error handling, but removal of
into_arrow_external_error