Add DataFusionError -> ArrowError conversion
#1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 22, 2022
Merged
alamb
commented
Jan 22, 2022
| @@ -74,6 +74,8 @@ pub enum DataFusionError { | |||
|
|
|||
| impl DataFusionError { | |||
| /// Wraps this [DataFusionError] as an [arrow::error::ArrowError]. | |||
| /// | |||
| /// TODO this can be removed in favor if the conversion below | |||
There was a problem hiding this comment.
Suggested change
| /// TODO this can be removed in favor if the conversion below | |
| /// TODO this can be removed in favor of the conversion below |
Why not remove this now? If we want to keep it, then it would be better to add a deprecated attribute.
There was a problem hiding this comment.
Sorry -- I removed it in #1645 (probably wasn't worth leaving a TODO) 🤔
houqp
approved these changes
Jan 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Resolves: #1642
Rationale for this change
Please see #1642
What changes are included in this PR?
impl From<DataFusionError> for ArrowErrorAre there any user-facing changes?
Possible to use
?now