Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SubqueryAlias in optimizer, physcial planner. #4293

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Support SubqueryAlias in optimizer, physcial planner. #4293

merged 1 commit into from
Nov 23, 2022

Conversation

jackwener
Copy link
Member

@jackwener jackwener commented Nov 19, 2022 •
edited
Loading

Which issue does this PR close?

Part of #4291 .

  • Support SubqueryAlias in physcial planner
  • Support SubquerAlias warp any plan in project_push_down
  • refactor optimize TableScan in project_push_down.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate optimizer Optimizer rules labels Nov 19, 2022
@jackwener
Copy link
Member Author

jackwener commented Nov 19, 2022 •
edited
Loading

I have test the condition use SubqueryAlias to replace alias-projection.
Basically no problem, but some optimizer rules don't consider SubqueryAlias to cause some problem.
So I will do more job in follow-up.

@jackwener jackwener changed the title Support SubqueryAlias in optimizer-executor. Support SubqueryAlias in optimizer, physcial planner. Nov 19, 2022
@jackwener jackwener mentioned this pull request Nov 19, 2022
Closed
@jackwener
Copy link
Member Author

PTAL, @andygrove @alamb @Dandandan

@jackwener
Copy link
Member Author

jackwener commented Nov 20, 2022 •
edited
Loading

After this PR, I will remove the alias-projection In the next PR.
Waiting for this PR merge, I will create a new PR for it.

@jackwener jackwener mentioned this pull request Nov 23, 2022
Merged
alamb
alamb approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refactor makes sense to me -- thank you @jackwener

Sorry for the delay in review -- I am somewhat behind in the backlog

@alamb alamb merged commit 07f65bf into apache:master Nov 23, 2022
alamb
alamb reviewed Nov 23, 2022
View reviewed changes
datafusion/optimizer/src/projection_push_down.rs
"SubqueryAlias should only wrap TableScan".to_string(),
)),
}
let new_required_columns =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a nice cleanup 👍

@ursabot
Copy link

ursabot commented Nov 23, 2022

Benchmark runs are scheduled for baseline = 72a4487 and contender = 07f65bf. 07f65bf is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@jackwener jackwener deleted the support_subquery_alias branch December 6, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate optimizer Optimizer rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackwener @ursabot @alamb