-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SubqueryAlias
in optimizer, physcial planner.
#4293
Conversation
I have test the condition use SubqueryAlias to replace alias-projection. |
SubqueryAlias
in optimizer-executor.SubqueryAlias
in optimizer, physcial planner.
PTAL, @andygrove @alamb @Dandandan |
After this PR, I will remove the alias-projection In the next PR. |
8e3cb7e
to
42acada
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This refactor makes sense to me -- thank you @jackwener
Sorry for the delay in review -- I am somewhat behind in the backlog
"SubqueryAlias should only wrap TableScan".to_string(), | ||
)), | ||
} | ||
let new_required_columns = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a nice cleanup 👍
Benchmark runs are scheduled for baseline = 72a4487 and contender = 07f65bf. 07f65bf is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Part of #4291 .
project_push_down
project_push_down
.Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?