Add Validity compute functions #134
Milestone
Comments
zeroshade
added a commit
to zeroshade/arrow-go
that referenced
this issue
Sep 22, 2024
zeroshade
added a commit
that referenced
this issue
Sep 25, 2024
Adding `is_null`, `is_not_null`, and `is_nan` functions and tests to the Compute implementations for Go. This also removes the `-ffast-math` option from the SIMD optimized compiler Makefile so that our comparisons properly handle `NaN` values (`-ffast-math` assumes that no values are `NaN` and removes the checks). `is_nan` can be easily implemented for float and double values by dispatching to `A != A`. Tests are also added for the new functions. Ultimately the driving force behind this is as these are necessary for implementing scanning reads in iceberg-go --------- Co-authored-by: Sutou Kouhei <kou@clear-code.com>
|
Closed by #135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should add the validity compute methods such as IsNull, IsNotNull and IsNaN to our implemented functions, along with the corresponding mappings for substrait expressions.
The text was updated successfully, but these errors were encountered: