Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modules aren't properly declared #466

Closed
lidavidm opened this issue Dec 26, 2024 · 3 comments · Fixed by #467
Closed

Modules aren't properly declared #466

lidavidm opened this issue Dec 26, 2024 · 3 comments · Fixed by #467
Labels
Type: bug Something isn't working

Comments

@lidavidm
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

  • org.apache.arrow.flight.grpc isn't exported
  • JDBC driver uses 'flight.sql.jdbc.core' which doesn't match other packages like 'org.apache.arrow.flight.core'
@lidavidm lidavidm added the Type: bug Something isn't working label Dec 26, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Dec 26, 2024
@lidavidm
feat(java): add module-info.java
62f6aa2 
Blocked by apache/arrow-java#466.

Fixes apache#2397.
@lidavidm lidavidm mentioned this issue Dec 26, 2024
Draft
@lidavidm
Copy link
Member Author

So it seems we can't fix the automatic module name for the JDBC driver since Avatica is packaged in a way that it can't become an automatic module :/

lidavidm added a commit to lidavidm/arrow-java that referenced this issue Dec 26, 2024
@lidavidm
apacheGH-466: Export namespace from Flight package
e4a71c8 
Fixes apache#466.
@lidavidm lidavidm mentioned this issue Dec 26, 2024
Merged
lidavidm added a commit to lidavidm/arrow-java that referenced this issue Dec 26, 2024
@lidavidm
apacheGH-466: Export namespace from Flight package
5aadea4 
Fixes apache#466.
@wgtmac
Copy link
Member

wgtmac commented Dec 30, 2024

So it seems we can't fix the automatic module name for the JDBC driver since Avatica is packaged in a way that it can't become an automatic module :/

Is it because Avatica is shaded with package name transformed? (It might be a dumb question since I'm still new to JPMS).

@lidavidm
Copy link
Member Author

I didn't save the error but IIRC it had to do with service providers

lidavidm added a commit that referenced this issue Dec 30, 2024
@lidavidm
GH-466: Export namespace from Flight package (#467)
5a418f9 
Fixes #466.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-466: Export namespace from Flight package lidavidm/arrow-java
2 participants
@lidavidm @wgtmac