Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-10: Add basic checks into pre-commit-config #435

Merged
merged 7 commits into from
Dec 26, 2024
Merged

Conversation

kiszk
Copy link
Member

@kiszk kiszk commented Dec 1, 2024

Fixes #10
Fixes #11
Removed gh 12 now

@kou
Copy link
Member

kou commented Dec 1, 2024

Could you add https://github.com/apache/arrow-go/blob/main/.editorconfig for shfmt?

@kiszk
Copy link
Member Author

kiszk commented Dec 1, 2024

Good catch, thank you.

.editconfig Outdated Show resolved Hide resolved
@kiszk kiszk marked this pull request as ready for review December 4, 2024 18:05
@kiszk kiszk marked this pull request as draft December 4, 2024 19:22
@kiszk kiszk marked this pull request as ready for review December 12, 2024 08:41
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to revert the YAML changes since we aren't using yamlfmt?

@kiszk
Copy link
Member Author

kiszk commented Dec 12, 2024

I see. I thought the reformatting of indentation made sense.
I will revert the changes in the YAML files.

@kiszk
Copy link
Member Author

kiszk commented Dec 23, 2024

Reverted changes in YAML files

@lidavidm lidavidm merged commit 480e1be into apache:main Dec 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pre-commit: shfmt pre-commit: ShellCheck
3 participants