Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinned version in arrow-flight's build-dependencies are causing conflicts #3876

Closed
sunng87 opened this issue Mar 16, 2023 · 2 comments · Fixed by #3927
Closed

Pinned version in arrow-flight's build-dependencies are causing conflicts #3876

sunng87 opened this issue Mar 16, 2023 · 2 comments · Fixed by #3927
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@sunng87
Copy link

sunng87 commented Mar 16, 2023

Describe the bug

When we add arrow-flight as a dependency to a project that already has prost-build as a build-dependency, there is a big chance that cargo will fail to select a valid version of prost-build and it cause build failure. The reason is we are using pinned versions of prost-build. When the project has a newer patch version for prost-build, for example, updated by dependabot, the pinned version will conflict with project's requirement for prost-build.

To Reproduce

This happens to any project that:

  • has prost-build as build-dependency, with version "0.11.8"
  • adds arrow-flight 35 as dependency, which pins prost-build to "0.11.7"
  • cargo build: conflict.

Possible solutions

There are some proposals to consider:

  • simply relax the pin
  • don't check in generated sources
  • use pinned prost-build as dev-dependency and generate the code via script or ci
@sunng87 sunng87 added the bug label Mar 16, 2023
@tustvold
Copy link
Contributor

Some context on this - #2616

use pinned prost-build as dev-dependency and generate the code via script or ci

I would be happy to review a PR that does this

@tustvold tustvold added enhancement Any new improvement worthy of a entry in the changelog and removed bug labels Mar 16, 2023
@sunng87 sunng87 mentioned this issue Mar 24, 2023
Closed
@sunng87
Copy link
Author

sunng87 commented Mar 24, 2023

@tustvold I just created a PR following a good practice from stackoverflow: #3926

tustvold added a commit to tustvold/arrow-rs that referenced this issue Mar 24, 2023
@tustvold
Move protoc generation to binary crate (apache#3876)
3e4b6ce
tustvold added a commit to tustvold/arrow-rs that referenced this issue Mar 24, 2023
@tustvold
Move protoc generation to binary crate (apache#3876)
d3a6621
tustvold added a commit to tustvold/arrow-rs that referenced this issue Mar 24, 2023
@tustvold
Move protoc generation to binary crate (apache#3876)
f325aff
@tustvold tustvold mentioned this issue Mar 24, 2023
Merged
tustvold added a commit that referenced this issue Mar 24, 2023
@tustvold
Move protoc generation to binary crate, unpin prost/tonic build (#3876)…
f330496 
… (#3927)

* Move protoc generation to binary crate (#3876)

* Review feedback

* Format

* Fix link
@tustvold tustvold added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate labels Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
2 participants
@sunng87 @tustvold