Change to use resolver v2, test more feature flag combinations in CI, fix errors (#1630)

.github/workflows/rust.yml

@@ -108,31 +108,43 @@ jobs:
 
           # run tests on all workspace members with default feature list
           cargo test
-
-          # Switch to arrow crate
-          cd arrow
-          # re-run tests on arrow crate to ensure
-          # all arrays are created correctly
-          cargo test --features=force_validate
-          cargo test --features=prettyprint
-          # run test on arrow crate with minimal set of features
-          cargo test --no-default-features
+
+          # re-run tests on arrow crate with all supported features
+          cargo test -p arrow --features=force_validate,prettyprint
+
+          # Test arrow examples
           cargo run --example builders
           cargo run --example dynamic_types
           cargo run --example read_csv
           cargo run --example read_csv_infer_schema
-          cargo check --no-default-features
+
+          # Test compilation of arrow library crate with different feature combinations
+          cargo check -p arrow
+          cargo check -p arrow --no-default-features
+
+          # Test compilation of arrow targets with different feature combinations
+          cargo check -p arrow --all-targets
+          cargo check -p arrow --no-default-features --all-targets
+          cargo check -p arrow --no-default-features --all-targets --features test_utils
 
-          # Switch to parquet crate
-          cd ../parquet
-          # re-run tests on parquet crate with async feature enabled
-          cargo test --features=async
-          cargo check --no-default-features
+          # re-run tests on arrow-flight with all features
+          cargo test -p arrow-flight --all-features
 
-          # Switch to arrow-flight
-          cd ../arrow-flight
-          cargo test --features=flight-sql-experimental
-          cargo check --no-default-features
+          # re-run tests on parquet crate with all features
+          cargo test -p parquet --all-features
+
+          # Test compilation of parquet library crate with different feature combinations
+          cargo check -p parquet
+          cargo check -p parquet --no-default-features
+          cargo check -p parquet --no-default-features --features arrow
+
+          # Test compilation of parquet targets with different feature combinations
+          cargo check -p parquet --all-targets
+          cargo check -p parquet --no-default-features --all-targets
+          cargo check -p parquet --no-default-features --features arrow --all-targets
+
+          # Test compilation of parquet_derive macro with different feature combinations
+          cargo check -p parquet_derive
 
   # test the --features "simd" of the arrow crate. This requires nightly.
   linux-test-simd:
@@ -173,12 +185,12 @@ jobs:
           export CARGO_TARGET_DIR="/github/home/target"
           cd arrow
           cargo test --features "simd"
-      - name: Check new project build with simd features
+      - name: Check compilation with simd features
         run: |
           export CARGO_HOME="/github/home/.cargo"
           export CARGO_TARGET_DIR="/github/home/target"
-          cd arrow/test/dependency/simd
-          cargo check
+          cargo check -p arrow --features simd
+          cargo check -p arrow --features simd --all-targets
 
   windows-and-macos:
     name: Test on ${{ matrix.os }} Rust ${{ matrix.rust }}
@@ -435,54 +447,3 @@ jobs:
           export CARGO_TARGET_DIR="/github/home/target"
           export RUSTDOCFLAGS="-Dwarnings"
           cargo doc --document-private-items --no-deps --workspace --all-features
-
-
-  # test builds with various feature flag combinations outside the main workspace
-  default-build:
-    name: Feature Flag Builds ${{ matrix.rust }}
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        arch: [amd64]
-        rust: [stable]
-    container:
-      image: ${{ matrix.arch }}/rust
-      env:
-        # Disable debug symbol generation to speed up CI build and keep memory down
-        RUSTFLAGS: "-C debuginfo=0"
-    steps:
-      - uses: actions/checkout@v2
-      - name: Cache Cargo
-        uses: actions/cache@v3
-        with:
-          path: /github/home/.cargo
-          # this key equals the ones on `linux-build-lib` for re-use
-          key: cargo-cache3-
-      - name: Cache Rust dependencies
-        uses: actions/cache@v3
-        with:
-          path: /github/home/target
-          # this key equals the ones on `linux-build-lib` for re-use
-          key: ${{ runner.os }}-${{ matrix.arch }}-target-cache3-${{ matrix.rust }}
-      - name: Setup Rust toolchain
-        uses: ./.github/actions/setup-builder
-        with:
-          rust-version: ${{ matrix.rust }}
-      - name: Arrow Build with default features
-        run: |
-          export CARGO_HOME="/github/home/.cargo"
-          export CARGO_TARGET_DIR="/github/home/target"
-          cd arrow/test/dependency/default-features
-          cargo check
-      - name: Arrow Build with default-features=false
-        run: |
-          export CARGO_HOME="/github/home/.cargo"
-          export CARGO_TARGET_DIR="/github/home/target"
-          cd arrow/test/dependency/no-default-features
-          cargo check
-      - name: Parquet Derive build with default-features
-        run: |
-          export CARGO_HOME="/github/home/.cargo"
-          export CARGO_TARGET_DIR="/github/home/target"
-          cd parquet_derive/test/dependency/default-features
-          cargo check

Cargo.toml

@@ -24,6 +24,7 @@ members = [
         "arrow-flight",
         "integration-testing",
 ]
+resolver = "2"
 
 # this package is excluded because it requires different compilation flags, thereby significantly changing
 # how it is compiled within the workspace, causing the whole workspace to be compiled from scratch

arrow/Cargo.toml

@@ -88,6 +88,7 @@ tempfile = "3"
 [[bench]]
 name = "aggregate_kernels"
 harness = false
+required-features = ["test_utils"]
 
 [[bench]]
 name = "array_from_vec"
@@ -96,6 +97,7 @@ harness = false
 [[bench]]
 name = "builder"
 harness = false
+required-features = ["test_utils"]
 
 [[bench]]
 name = "buffer_bit_ops"
@@ -104,6 +106,7 @@ harness = false
 [[bench]]
 name = "boolean_kernels"
 harness = false
+required-features = ["test_utils"]
 
 [[bench]]
 name = "boolean_append_packed"
@@ -112,22 +115,27 @@ harness = false
 [[bench]]
 name = "arithmetic_kernels"
 harness = false
+required-features = ["test_utils"]
 
 [[bench]]
 name = "cast_kernels"
 harness = false
+required-features = ["test_utils"]
 
 [[bench]]
 name = "comparison_kernels"
 harness = false
+required-features = ["test_utils"]
 
 [[bench]]
 name = "filter_kernels"
 harness = false
+required-features = ["test_utils"]
 
 [[bench]]
 name = "take_kernels"
 harness = false
+required-features = ["test_utils"]
 
 [[bench]]
 name = "length_kernel"
@@ -140,10 +148,12 @@ harness = false
 [[bench]]
 name = "sort_kernel"
 harness = false
+required-features = ["test_utils"]
 
 [[bench]]
 name = "partition_kernels"
 harness = false
+required-features = ["test_utils"]
 
 [[bench]]
 name = "csv_writer"
@@ -156,6 +166,7 @@ harness = false
 [[bench]]
 name = "equal"
 harness = false
+required-features = ["test_utils"]
 
 [[bench]]
 name = "array_slice"
@@ -164,18 +175,22 @@ harness = false
 [[bench]]
 name = "concatenate_kernel"
 harness = false
+required-features = ["test_utils"]
 
 [[bench]]
 name = "mutable_array"
 harness = false
+required-features = ["test_utils"]
 
 [[bench]]
 name = "buffer_create"
 harness = false
+required-features = ["test_utils"]
 
 [[bench]]
 name = "substring_kernels"
 harness = false
+required-features = ["test_utils"]
 
 [[bench]]
 name = "array_data_validate"

arrow/examples/read_csv.rs

@@ -35,7 +35,8 @@ fn main() {
             Field::new("lng", DataType::Float64, false),
         ]);
 
-        let file = File::open("test/data/uk_cities.csv").unwrap();
+        let path = format!("{}/test/data/uk_cities.csv", env!("CARGO_MANIFEST_DIR"));
+        let file = File::open(path).unwrap();
 
         let mut csv =
             csv::Reader::new(file, Arc::new(schema), false, None, 1024, None, None, None);

arrow/examples/read_csv_infer_schema.rs

@@ -26,7 +26,11 @@ use std::fs::File;
 fn main() {
     #[cfg(feature = "csv")]
     {
-        let file = File::open("test/data/uk_cities_with_headers.csv").unwrap();
+        let path = format!(
+            "{}/test/data/uk_cities_with_headers.csv",
+            env!("CARGO_MANIFEST_DIR")
+        );
+        let file = File::open(path).unwrap();
         let builder = csv::ReaderBuilder::new()
             .has_header(true)
             .infer_schema(Some(100));