Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support RFC3339 style timestamps in arrow-json #3449

Merged
merged 8 commits into from
Jan 6, 2023
Merged

support RFC3339 style timestamps in arrow-json #3449

merged 8 commits into from
Jan 6, 2023

Conversation

JayjeetAtGithub
Copy link
Contributor

Which issue does this PR close?

Closes #3416

What changes are included in this PR?

  • Modify array_value_to_string to print a trailing Z in case UTC timestamps
  • Use array_value_to_string inside arrow-json to write out timestamps in RFC3339
  • Add/Modify unit tests

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 4, 2023
@JayjeetAtGithub JayjeetAtGithub changed the title Use tz json support RFC3339 style timestamps in arrow-json Jan 4, 2023
@JayjeetAtGithub JayjeetAtGithub changed the title support RFC3339 style timestamps in arrow-json support RFC3339 style timestamps in arrow-json Jan 4, 2023
@JayjeetAtGithub JayjeetAtGithub mentioned this pull request Jan 4, 2023
Closed
tustvold
tustvold reviewed Jan 4, 2023
View reviewed changes
arrow-json/src/writer.rs Outdated
}

#[test]
#[cfg(feature = "chrono-tz")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test should work even with chrono-tz disabled, this is only needed to parse timezones like UTC

tustvold
tustvold approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the chrono-tz feature added to arrow-json, otherwise this looks good

@tustvold tustvold added the api-change Changes to the arrow API label Jan 4, 2023
@JayjeetAtGithub
Copy link
Contributor Author

@tustvold @alamb I have done the required changes.

@tustvold tustvold merged commit acefeef into apache:master Jan 6, 2023
@tustvold
Copy link
Contributor

tustvold commented Jan 6, 2023

Thank you

@ursabot
Copy link

ursabot commented Jan 6, 2023

Benchmark runs are scheduled for baseline = 2d2d0a3 and contender = acefeef. acefeef is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb
Copy link
Contributor

alamb commented Jan 6, 2023

Thank you @JayjeetAtGithub !

@JayjeetAtGithub JayjeetAtGithub mentioned this pull request Jan 6, 2023
Closed
@tustvold tustvold mentioned this pull request Jan 16, 2023
Merged
@JayjeetAtGithub JayjeetAtGithub deleted the use_tz_json branch September 1, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold Awaiting requested review from tustvold

Assignees
No one assigned
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use RFC3339 style timestamps in arrow-json
4 participants
@JayjeetAtGithub @tustvold @ursabot @alamb