Add SchemaBuilder::remove (#4952) #4964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Code and tests look good to me -- thank you @tustvold
One thing I noticed is that there is no way to go directly from Schema to SchemaBuilder (though there is a impl from<Fields>)
I wonder if we should consider something like Schema::into_builder() and/or an impl From<Schema>
Yeah, I think we would need to make SchemaBuilder understand schema metadata for this, but definitely would make sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4952
Relates to #4908
Rationale for this change
Adds
SchemaBuilder::removeand makes it more discoverable fromFieldsWhat changes are included in this PR?
Are there any user-facing changes?