Add arrow_cast::base64 and document usage in arrow_json #4975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Oct 23, 2023
| @@ -50,10 +50,12 @@ half = { version = "2.1", default-features = false } | |||
| num = { version = "0.4", default-features = false, features = ["std"] } | |||
| lexical-core = { version = "^0.8", default-features = false, features = ["write-integers", "write-floats", "parse-integers", "parse-floats"] } | |||
| comfy-table = { version = "7.0", optional = true, default-features = false } | |||
| base64 = "0.21" | |||
There was a problem hiding this comment.
This crate is incredibly common, and has no additional dependencies, so I am inclined to think this is fine
tustvold
commented
Oct 23, 2023
| /// Base64 decode each element of `array` with the provided `engine` | ||
| pub fn b64_decode<E: Engine, O: OffsetSizeTrait>( | ||
| engine: &E, | ||
| array: &GenericBinaryArray<O>, |
There was a problem hiding this comment.
It would perhaps be more symmetrical to take a GenericStringArray but it seems unnecessary to mandate UTF-8 data, when the decoding process effectively verifies it anyway
crepererum
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4945
Closes #4967
Rationale for this change
How to safely roundtrip binary data through text formats like JSON and CSV comes up a lot. This PR therefore adds functions to perform base64 conversion and documents how to use them
What changes are included in this PR?
Are there any user-facing changes?