Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Arrow Flight support for StringViewArray and BinaryViewArray #5601

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

XiangpengHao
Copy link
Contributor

Which issue does this PR close?

Closes #5507.

Rationale for this change

To confirm that StringViewArray and BinaryViewArray works with Arrow Flight format.

What changes are included in this PR?

Just added a few test case to show that they should work, and they indeed work.
Nothing important really, it just works as @alamb said.

Please let me know if I need to make some more complex test cases like ones we added to in the IPC reader test cases.

Are there any user-facing changes?

No

@github-actions github-actions bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate labels Apr 8, 2024
@alamb
Copy link
Contributor

alamb commented Apr 8, 2024

Thanks @XiangpengHao !

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @XiangpengHao 😍

@alamb alamb changed the title Arrow Flight format support for StringViewArray and BinaryViewArray Add tests for Arrow Flight support for StringViewArray and BinaryViewArray Apr 8, 2024
@alamb alamb merged commit 51c1b4b into apache:master Apr 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrow Flight format support for StringViewArray and BinaryViewArray
2 participants