-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding compact check functionality to GenericByteViewArray #5720
base: master
Are you sure you want to change the base?
Conversation
this part contains compact check functionality for GenericByteViewArray. Signed-off-by: 蔡略 <cailue@bupt.edu.cn>
Signed-off-by: 蔡略 <cailue@bupt.edu.cn>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @ClSlaid
Would it be possible please to make a PR with ::gc()
as described on #5720? first?
I think the logic to check for compacted is a nice (but new) additional API
This PR doesn't add any new APIs to ByteViewArray -- if we want to consider this code, perhaps we could add one like `GenericByteViewArray::is_compacted()?
But again i consider this a separate task
Signed-off-by: 蔡略 <cailue@bupt.edu.cn>
I'd implement this first, instead of simultaneously or later. So that I will not bother resolving git conflict 🪢, or have to implement a wasteful full-copying GC algorithm first. :P
As you wish, a new
Exactly. |
@alamb Would you kindly retrigger the CI? I don't see anything wrong with my code. |
I believe the CI errors are due to issues that are subsequently fixed (@tustvold fixed #5719 this morning) Thus if you merge up from the |
I am very excited to see I still don't fully understand the need for the compact check API in this PR. Perhaps we can make a PR for gc first and then revisit this? |
will rewrite after GC merged |
This part contains compact check functionality for GenericByteViewArray.
Which issue does this PR close?
Rationale for this change
Part of #5707.
What changes are included in this PR?
GenericByteViewArray
to check if its representation is compact.Are there any user-facing changes?
None.