Remove deprecated comparison kernels (#4733) #5768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
May 15, 2024
There was a problem hiding this comment.
Looks good to me. I went through this whole PR and I think it looks like a nice cleanup. 🏆
TIL Array::new_scalar as the preferred way of creating the scalars 👍
Also a good one to get in before the 53 release (in addition to unblocking fixing intervals)
cc @viirya and @jhorstmann
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4733
Rationale for this change
Cleans up old code, and unblocks changing intervals to a non-integral representation (which cannot be supported by the legacy comparison kernels) and fixing #5654
What changes are included in this PR?
Are there any user-facing changes?