Workaround for missing Parquet page indexes in ParquetMetadaReader
#6450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
alamb
changed the title
ParquetMetadaReader
alamb
reviewed
Sep 25, 2024
alamb
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Thank you @etseidl -- this change makes sense to me. Presumably this will make replacing the existing APIs without test changes possble, so I think it is ok for now that it isn't covered by tests.
I left some small suggestions for comments, but I don't think they are necessary to merge
Thanks again
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Yes, that's the hope. As deprecated methods are replaced by this API, their tests should cover the new API. |
|
Pushed a small commit to make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #6447
Rationale for this change
There is an inconsistency in how the various Parquet metadata parsing APIs handle files that lack page indexes. This PR temporarily modifies
ParquetMetaDataReaderto match the current behavior inparquet::file::metadata::page_index::index_reader(return empty vectors rather thanNone).What changes are included in this PR?
Are there any user-facing changes?
No