Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R][CI] Update test-r-devdocs on Windows to build UCRT and don't pin to R 4.1 #31757

Open
asfimport opened this issue Apr 27, 2022 · 1 comment

Comments

@asfimport
Copy link
Collaborator

The failed devdocs builds were fixed by pinning the R version to 4.1 in ARROW-16375 but we should instead just add UCRT to the build and not pin the version

Reporter: Nicola Crane / @thisisnic

Note: This issue was originally created as ARROW-16376. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Will Jones / @wjones127:
If we can, it would be nice to use the new RTools 4.2, but if there are blocking issues there we should be able to just use the UCRT in RTools 4.0.

In the instructions for Windows, we should also suggest using lld (the LLVM linker) instead of ld, which is compatible for the version of GCC that UCRT MSYS2 uses (10, I think?) and supposedly provides substantially better link times (on my local box linking represents about 10 minutes of build time with mingw64 :().

kou pushed a commit that referenced this issue Jul 20, 2023
### Rationale for this change

The test-r-devdocs job is failing. It is failing because we are pinning a version of R that is so old that CRAN no longer serves binaries (#31757), so some of the package builds are failing.

### What changes are included in this PR?

Use the `setup-r-dependencies` action which either installs the correct build dependencies or uses older binary versions to avoid building from source (or both).

### Are these changes tested?

Yes, as part of the test-r-devdocs job.

### Are there any user-facing changes?

No.
* Closes: #36750

Authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this issue Aug 20, 2023
### Rationale for this change

The test-r-devdocs job is failing. It is failing because we are pinning a version of R that is so old that CRAN no longer serves binaries (apache#31757), so some of the package builds are failing.

### What changes are included in this PR?

Use the `setup-r-dependencies` action which either installs the correct build dependencies or uses older binary versions to avoid building from source (or both).

### Are these changes tested?

Yes, as part of the test-r-devdocs job.

### Are there any user-facing changes?

No.
* Closes: apache#36750

Authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
### Rationale for this change

The test-r-devdocs job is failing. It is failing because we are pinning a version of R that is so old that CRAN no longer serves binaries (apache#31757), so some of the package builds are failing.

### What changes are included in this PR?

Use the `setup-r-dependencies` action which either installs the correct build dependencies or uses older binary versions to avoid building from source (or both).

### Are these changes tested?

Yes, as part of the test-r-devdocs job.

### Are there any user-facing changes?

No.
* Closes: apache#36750

Authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant