Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release][Ruby] Remove pins from glib section of release verification script #44415

Closed
amoeba opened this issue Oct 15, 2024 · 1 comment · Fixed by #44407
Closed

[Release][Ruby] Remove pins from glib section of release verification script #44415

amoeba opened this issue Oct 15, 2024 · 1 comment · Fixed by #44407

Comments

@amoeba
Copy link
Member

amoeba commented Oct 15, 2024

Describe the bug, including details regarding any error messages, version, and platform.

Due to an upstream issue with the glib feedstock (conda-forge/glib-feedstock#191), we patched the release verification script to pin glib (#44270) and Python (#44382). The changes in those PRs were made just to get the 18.0.0 release passing verification. Now that conda-forge/glib-feedstock#191 has been fixed, we can revert these changes.

Component(s)

Release, Ruby

amoeba added a commit that referenced this issue Oct 15, 2024
…rification script (#44407)

### Rationale for this change

We can remove these pins now that conda-forge/glib-feedstock#191 has been closed. I've tested on my own crossbow and will test here momentarily. This effectively reverts #44270 and #44268.

### What changes are included in this PR?

Tweaks to release release verification script, specifically removing recently-added pins.

### Are these changes tested?

Yes: https://github.com/amoeba/crossbow/actions/runs/11335070956/job/31522511285.

### Are there any user-facing changes?

No.

Closes #44415.
* GitHub Issue: #44415

Authored-by: Bryce Mecum <petridish@gmail.com>
Signed-off-by: Bryce Mecum <petridish@gmail.com>
@amoeba
Copy link
Member Author

amoeba commented Oct 15, 2024

Issue resolved by pull request 44407
#44407

@amoeba amoeba added this to the 19.0.0 milestone Oct 15, 2024
@raulcd raulcd modified the milestones: 19.0.0, 18.0.0 Oct 15, 2024
raulcd pushed a commit that referenced this issue Oct 15, 2024
…rification script (#44407)

### Rationale for this change

We can remove these pins now that conda-forge/glib-feedstock#191 has been closed. I've tested on my own crossbow and will test here momentarily. This effectively reverts #44270 and #44268.

### What changes are included in this PR?

Tweaks to release release verification script, specifically removing recently-added pins.

### Are these changes tested?

Yes: https://github.com/amoeba/crossbow/actions/runs/11335070956/job/31522511285.

### Are there any user-facing changes?

No.

Closes #44415.
* GitHub Issue: #44415

Authored-by: Bryce Mecum <petridish@gmail.com>
Signed-off-by: Bryce Mecum <petridish@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants