ARROW-13554: [C++] Remove deprecated Scanner::Scan #11991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2239,10 +2233,6 @@ cdef class Scanner(_Weakrefable): | |||
| use_threads : bool, default True | |||
| If enabled, then maximum parallelism will be used determined by | |||
| the number of available CPU cores. | |||
| use_async : bool, default False | |||
There was a problem hiding this comment.
It seems that in Python, this keyword was not actually deprecated (in docs or deprecation warning)?
Therefore, we could maybe still temporary just keep this keyword in the signature (without that it does anything, except from raising a warning if specified by the user, or something like that)
There was a problem hiding this comment.
I added the parameters back in. PTAL. One thing I wasn't sure of...
All of the places the parameter was declared it was a bint which means I couldn't change the default to None which means there was no good way to tell if the user specified it or not.
So I just made the default True and emit the warning if the user specifies False. However, if a user has:
dataset.to_table(use_async=True) they will not get the warning.
Alternatively, I could change the cython type from bint to object. Then I should be able to warn on both use_async=True and use_async=False. Would this possible have any backwards compatibility ramifications?
There was a problem hiding this comment.
This was bugging me so I went ahead and played around with it. I don't see any consequences if I change bint use_async=True to object use_async = None and that allows me to emit the deprecation warning on both use_async=True and use_async=False (i.e. emit a warning if the user uses the flag in any way).
There was a problem hiding this comment.
I also can't think of any concern for changing bint to object (the other way around would limit what you can pass, but for here it just broadens what you can pass, so that should not be a compatibility issue)
westonpace
force-pushed
the
feature/ARROW-13554--unscan-sync-scanner
branch
2 times, most recently
from
582ae32
to
189dce2
Compare
westonpace
force-pushed
the
feature/ARROW-13554--unscan-sync-scanner
branch
from
0b3397d
to
4fd7b1e
Compare
|
The only failure remaining is a Java failure. Unfortunately, the test failure is missing line numbers so I'm not sure exactly what assert is failing (it expects 2 but I can't find any assert expecting 2 in the test case) so I'll try and reproduce it locally. This is ready for review in the meantime. |
lidavidm
reviewed
Jan 6, 2022
lidavidm
approved these changes
Jan 7, 2022
|
|
||
| for (size_t i = 0; i < exprs.size(); ++i) { | ||
| if (auto ref = exprs[i].field_ref()) { | ||
| if (!ref->name()) return NestedFieldRefsNotImplemented(); |
There was a problem hiding this comment.
I'll rebase #11704 when this lands.
I just created ARROW-15283 |
… arrays. Putting in an expensive fix to see if it fixes the test. Ideally we can do something better but I may have to push that to a future PR
…test, reverted unintended style changes from cglib, moved projectiondescr factory methods into the struct
…e concatenate if there is an offset. Added a comment explaining the situation and referencing a follow-up PR
…n the cglib files
…ectionDescr::FromXyz for consistency with other parts of the code
… removing the field outright...yet
…give a deprecation warning on use_async=True AND use_async=False
westonpace
force-pushed
the
feature/ARROW-13554--unscan-sync-scanner
branch
from
da58e06
to
3629ed1
Compare
|
Benchmark runs are scheduled for baseline = 43bc33b and contender = 2e8b836. 2e8b836 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
This might break test-skyhook-integration (cc: @JayjeetAtGithub): https://github.com/ursacomputing/crossbow/runs/4771425719?check_suite_focus=true |
|
Oh, sorry. I haven't seen it yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.