Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17410: [JS][Integration] Downgrade zlib for integration #13885

Merged
merged 2 commits into from
Aug 15, 2022
Merged

ARROW-17410: [JS][Integration] Downgrade zlib for integration #13885

merged 2 commits into from
Aug 15, 2022

Conversation

zeroshade
Copy link
Member

Downgrading to zlib=1.2.11 fixes the existing issue as reported in madler/zlib#613 until the patch is released.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-17410

@lidavidm
Copy link
Member

looks like that fixed it!

@zeroshade zeroshade merged commit 3a59bc0 into apache:master Aug 15, 2022
@zeroshade zeroshade deleted the arrow-17410-js-integration branch August 15, 2022 19:43
ksuarez1423 pushed a commit to ksuarez1423/arrow that referenced this pull request Aug 15, 2022
@zeroshade @ksuarez1423
ARROW-17410: [JS][Integration] Downgrade zlib for integration (apache…
5f6648e 
…#13885)

Downgrading to `zlib=1.2.11` fixes the existing issue as reported in madler/zlib#613 until the patch is released.

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
ksuarez1423 pushed a commit to ksuarez1423/arrow that referenced this pull request Aug 15, 2022
@zeroshade @ksuarez1423
ARROW-17410: [JS][Integration] Downgrade zlib for integration (apache…
7e62a45 
…#13885)

Downgrading to `zlib=1.2.11` fixes the existing issue as reported in madler/zlib#613 until the patch is released.

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@ursabot
Copy link

ursabot commented Aug 15, 2022

Benchmark runs are scheduled for baseline = a270afc and contender = 3a59bc0. 3a59bc0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.17% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.55% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.32% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 3a59bc02 ec2-t3-xlarge-us-east-2
[Failed] 3a59bc02 test-mac-arm
[Failed] 3a59bc02 ursa-i9-9960x
[Finished] 3a59bc02 ursa-thinkcentre-m75q
[Finished] a270afc9 ec2-t3-xlarge-us-east-2
[Failed] a270afc9 test-mac-arm
[Failed] a270afc9 ursa-i9-9960x
[Finished] a270afc9 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Aug 15, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@zeroshade @zagto
ARROW-17410: [JS][Integration] Downgrade zlib for integration (apache…
f707c62 
…#13885)

Downgrading to `zlib=1.2.11` fixes the existing issue as reported in madler/zlib#613 until the patch is released.

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@asfimport asfimport mentioned this pull request Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

@lidavidm lidavidm lidavidm approved these changes

@kszucs kszucs Awaiting requested review from kszucs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zeroshade @lidavidm @ursabot @tustvold