GH-34316: [Python] FixedSizeListArray.from_arrays supports mask parameter #39396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
Component: Python
awaiting review
LucasG0
force-pushed
the
fsla_from_arrays_mask
branch
2 times, most recently
from
a6be8eb
to
6b11b42
Compare
wjones127
requested changes
Jan 2, 2024
cpp/src/arrow/array/array_nested.h
Outdated
Comment on lines
604
to
607
| static Result<std::shared_ptr<Array>> FromArrays( | ||
| const std::shared_ptr<Array>& values, | ||
| int32_t list_size, | ||
| std::shared_ptr<Buffer> null_bitmap = NULLPTR); |
There was a problem hiding this comment.
Other methods that allow passing a null bitmap (such as ListArray::FromArrays()) support another parameter null_count to pass the computed null count. Could we support that parameter in C++ as well? We don't need to expose it in Python.
arrow/cpp/src/arrow/array/array_nested.h
Lines 174 to 178 in 6b11b42
github-actions
bot
added
awaiting review
LucasG0
force-pushed
the
fsla_from_arrays_mask
branch
from
6b11b42
to
31157b5
Compare
github-actions
bot
added
awaiting review
LucasG0
force-pushed
the
fsla_from_arrays_mask
branch
from
31157b5
to
1708fa7
Compare
wjones127
approved these changes
Jan 3, 2024
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 0e597ab. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
clayburn
pushed a commit
to clayburn/arrow
that referenced
this pull request
Jan 23, 2024
… parameter (apache#39396) ### What changes are included in this PR? Add `mask` / `null_bitmap` parameters in corresponding Cython / C++ `FixedSizeListArray` methods, and propagate this bitmap instead of using the current dummy `validity_buf`. ### Are these changes tested? Yes ### Are there any user-facing changes? Yes, `mask` parameter has been added to `FixedSizeListArray.from_arrays` * Closes: apache#34316 Authored-by: LucasG0 <guillermou.lucas@gmail.com> Signed-off-by: Will Jones <willjones127@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
… parameter (apache#39396) ### What changes are included in this PR? Add `mask` / `null_bitmap` parameters in corresponding Cython / C++ `FixedSizeListArray` methods, and propagate this bitmap instead of using the current dummy `validity_buf`. ### Are these changes tested? Yes ### Are there any user-facing changes? Yes, `mask` parameter has been added to `FixedSizeListArray.from_arrays` * Closes: apache#34316 Authored-by: LucasG0 <guillermou.lucas@gmail.com> Signed-off-by: Will Jones <willjones127@gmail.com>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Feb 28, 2024
… parameter (apache#39396) ### What changes are included in this PR? Add `mask` / `null_bitmap` parameters in corresponding Cython / C++ `FixedSizeListArray` methods, and propagate this bitmap instead of using the current dummy `validity_buf`. ### Are these changes tested? Yes ### Are there any user-facing changes? Yes, `mask` parameter has been added to `FixedSizeListArray.from_arrays` * Closes: apache#34316 Authored-by: LucasG0 <guillermou.lucas@gmail.com> Signed-off-by: Will Jones <willjones127@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
Add
mask/null_bitmapparameters in corresponding Cython / C++FixedSizeListArraymethods, and propagate this bitmap instead of using the current dummyvalidity_buf.Are these changes tested?
Yes
Are there any user-facing changes?
Yes,
maskparameter has been added toFixedSizeListArray.from_arraysmaskinFixedSizeListArray.from_arrays#34316