-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-41145: [R][CI] test-r-dev-duckdb fails installing duckdb #41152
Conversation
|
@github-actions crossbow submit test-r-dev-duckdb |
Revision: dc8b10b Submitted crossbow builds: ursacomputing/crossbow @ actions-609f297d63
|
The most recent success appears to be here: https://github.com/ursacomputing/crossbow/actions/runs/8319414856/job/22762704075 The oldest failure is here: https://github.com/ursacomputing/crossbow/actions/runs/8335536023/job/22811196734 So it seems to have failed on March 17th though I cannot find any interesting culprit in the commit log for duckdb-r or dbi in that date range. |
There were some non-UTF8 additions to the duckdb DESCRIPTION 3 weeks ago, that could be the issue: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
### Rationale for this change An error is received installing R duckdb: ``` #15 18.13 > remotes::install_github('duckdb/duckdb-r', build = FALSE) #15 18.27 Error: Failed to install 'unknown package' from **GitHub:** #15 18.27 Line starting 'Roxyg ...' is malformed! ``` Some searching seems to suggest that this is because R cannot process UTF-8 characters in DESCRIPTION files if the `LANG` is set to `C`. ### What changes are included in this PR? The `LANG` is set to `C.UTF-8` in the dockerfile for this CI job ### Are these changes tested? The change only affects a test ### Are there any user-facing changes? No * GitHub Issue: #41145 Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6269317. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 15 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…ache#41152) ### Rationale for this change An error is received installing R duckdb: ``` apache#15 18.13 > remotes::install_github('duckdb/duckdb-r', build = FALSE) apache#15 18.27 Error: Failed to install 'unknown package' from **GitHub:** apache#15 18.27 Line starting 'Roxyg ...' is malformed! ``` Some searching seems to suggest that this is because R cannot process UTF-8 characters in DESCRIPTION files if the `LANG` is set to `C`. ### What changes are included in this PR? The `LANG` is set to `C.UTF-8` in the dockerfile for this CI job ### Are these changes tested? The change only affects a test ### Are there any user-facing changes? No * GitHub Issue: apache#41145 Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
…ache#41152) ### Rationale for this change An error is received installing R duckdb: ``` apache#15 18.13 > remotes::install_github('duckdb/duckdb-r', build = FALSE) apache#15 18.27 Error: Failed to install 'unknown package' from **GitHub:** apache#15 18.27 Line starting 'Roxyg ...' is malformed! ``` Some searching seems to suggest that this is because R cannot process UTF-8 characters in DESCRIPTION files if the `LANG` is set to `C`. ### What changes are included in this PR? The `LANG` is set to `C.UTF-8` in the dockerfile for this CI job ### Are these changes tested? The change only affects a test ### Are there any user-facing changes? No * GitHub Issue: apache#41145 Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
…ache#41152) ### Rationale for this change An error is received installing R duckdb: ``` apache#15 18.13 > remotes::install_github('duckdb/duckdb-r', build = FALSE) apache#15 18.27 Error: Failed to install 'unknown package' from **GitHub:** apache#15 18.27 Line starting 'Roxyg ...' is malformed! ``` Some searching seems to suggest that this is because R cannot process UTF-8 characters in DESCRIPTION files if the `LANG` is set to `C`. ### What changes are included in this PR? The `LANG` is set to `C.UTF-8` in the dockerfile for this CI job ### Are these changes tested? The change only affects a test ### Are there any user-facing changes? No * GitHub Issue: apache#41145 Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Rationale for this change
An error is received installing R duckdb:
Some searching seems to suggest that this is because R cannot process UTF-8 characters in DESCRIPTION files if the
LANG
is set toC
.What changes are included in this PR?
The
LANG
is set toC.UTF-8
in the dockerfile for this CI jobAre these changes tested?
The change only affects a test
Are there any user-facing changes?
No