ARROW-736: [Python] Mixed-type object DataFrame columns should not silently co… #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
force-pushed
the
ARROW-736
branch
3 times, most recently
from
da635ce
to
2702cc6
Compare
|
needs rebase and cpplint fix |
cpcloud
changed the title
wesm
reviewed
Mar 31, 2017
| Py_DECREF(type_name); | ||
| Py_DECREF(type); | ||
| DCHECK_NE(PyErr_Occurred(), nullptr) << "Call to PyObject_AsUTF8String(...) returned " | ||
| "NULL but PyErr_Occurred() was NULL"; |
There was a problem hiding this comment.
Yikes. Perhaps we should develop some tools to help with the Python C API in C++. I have tried to use the OwnedRef to handle RAII-based DECREF
There was a problem hiding this comment.
Nice, I'll do that.
|
|
||
| Py_DECREF(bytes_obj); | ||
| Py_DECREF(type_name); | ||
| Py_DECREF(type); |
There was a problem hiding this comment.
You could try using the OwnedRef for these, save you a bunch of DECREFs per above
| namespace arrow { | ||
| namespace py { | ||
|
|
||
| TEST(BuiltinConversionTest, TestMixedTypeFails) { |
There was a problem hiding this comment.
Can you put this in pandas-test and rename that test file to python-test.cc instead?
|
@wesm good to merge? green builds :) |
2 tasks
leifwalsh
pushed a commit
to leifwalsh/arrow
that referenced
this pull request
Apr 1, 2017
…lently co… …erce to an Arrow type by default Author: Phillip Cloud <cpcloud@gmail.com> Closes apache#465 from cpcloud/ARROW-736 and squashes the following commits: fd09def [Phillip Cloud] Update cmake bcf6236 [Phillip Cloud] Rename and move 4a18014 [Phillip Cloud] Move test e80efe1 [Phillip Cloud] Use OwnedRef instead of horror b2df3e9 [Phillip Cloud] Fix python error handling and make compatible with python27 84d33b4 [Phillip Cloud] ARROW-736: Mixed-type object DataFrame columns should not silently coerce to an Arrow type by default
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 2, 2018
…types Author: Deepak Majeti <deepak.majeti@hpe.com> Closes apache#465 from majetideepak/PARQUET-979 and squashes the following commits: 3b18173 [Deepak Majeti] improve naming and ColumnProperties class a888aa4 [Deepak Majeti] Add an option to specify max stats size c103c4f [Deepak Majeti] make format cf0260c [Deepak Majeti] PARQUET-979: [C++] Limit size of min, max or disable stats for long binary types
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 4, 2018
…types Author: Deepak Majeti <deepak.majeti@hpe.com> Closes apache#465 from majetideepak/PARQUET-979 and squashes the following commits: 3b18173 [Deepak Majeti] improve naming and ColumnProperties class a888aa4 [Deepak Majeti] Add an option to specify max stats size c103c4f [Deepak Majeti] make format cf0260c [Deepak Majeti] PARQUET-979: [C++] Limit size of min, max or disable stats for long binary types Change-Id: I2843608b1848b6d85ac226064dd4c5ec93e40f47
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 6, 2018
…types Author: Deepak Majeti <deepak.majeti@hpe.com> Closes apache#465 from majetideepak/PARQUET-979 and squashes the following commits: 3b18173 [Deepak Majeti] improve naming and ColumnProperties class a888aa4 [Deepak Majeti] Add an option to specify max stats size c103c4f [Deepak Majeti] make format cf0260c [Deepak Majeti] PARQUET-979: [C++] Limit size of min, max or disable stats for long binary types Change-Id: I2843608b1848b6d85ac226064dd4c5ec93e40f47
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 7, 2018
…types Author: Deepak Majeti <deepak.majeti@hpe.com> Closes apache#465 from majetideepak/PARQUET-979 and squashes the following commits: 3b18173 [Deepak Majeti] improve naming and ColumnProperties class a888aa4 [Deepak Majeti] Add an option to specify max stats size c103c4f [Deepak Majeti] make format cf0260c [Deepak Majeti] PARQUET-979: [C++] Limit size of min, max or disable stats for long binary types Change-Id: I2843608b1848b6d85ac226064dd4c5ec93e40f47
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
…types Author: Deepak Majeti <deepak.majeti@hpe.com> Closes apache#465 from majetideepak/PARQUET-979 and squashes the following commits: 3b18173 [Deepak Majeti] improve naming and ColumnProperties class a888aa4 [Deepak Majeti] Add an option to specify max stats size c103c4f [Deepak Majeti] make format cf0260c [Deepak Majeti] PARQUET-979: [C++] Limit size of min, max or disable stats for long binary types Change-Id: I2843608b1848b6d85ac226064dd4c5ec93e40f47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erce to an Arrow type by default