Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-8740: [CI] Fix archery option in pandas master cron test #7113

Closed
wants to merge 1 commit into from

Conversation

kszucs
Copy link
Member

@kszucs kszucs commented May 6, 2020

No description provided.

@github-actions
Copy link

github-actions bot commented May 6, 2020

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@wesm wesm changed the title [CI] Fix archery option in pandas master cron test [MINOR][CI] Fix archery option in pandas master cron test May 6, 2020
@wesm
Copy link
Member

wesm commented May 6, 2020

Hm, there was a test failure

____________ TestConvertMetadata.test_table_column_subset_metadata _____________

self = <pyarrow.tests.test_pandas.TestConvertMetadata object at 0x7f759a900960>

    def test_table_column_subset_metadata(self):
        # ARROW-1883
        # non-default index
        for index in [
                pd.Index(['a', 'b', 'c'], name='index'),
                pd.date_range("2017-01-01", periods=3, tz='Europe/Brussels')]:
            df = pd.DataFrame({'a': [1, 2, 3],
                               'b': [.1, .2, .3]}, index=index)
            table = pa.Table.from_pandas(df)
    
            table_subset = table.remove_column(1)
            result = table_subset.to_pandas()
>           tm.assert_frame_equal(result, df[['a']])
E           AssertionError: (None, <Day>)

opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/test_pandas.py:506: AssertionError

@wesm wesm changed the title [MINOR][CI] Fix archery option in pandas master cron test [CI] Fix archery option in pandas master cron test May 6, 2020
@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented May 7, 2020

The failure in pandas master is covered in https://issues.apache.org/jira/browse/ARROW-8643. It's an easy fix, but I am discussing on the pandas side whether the change shouldn't be reverted there (now, until that discussion is settled, it's maybe easier to fix the test here anyway, to avoid the failure. Will do a quick PR)

@jorisvandenbossche
Copy link
Member

-> #7124

@kszucs kszucs changed the title [CI] Fix archery option in pandas master cron test ARROW-8740: [CI] Fix archery option in pandas master cron test May 8, 2020
@github-actions
Copy link

github-actions bot commented May 8, 2020

Copy link
Member Author

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants