-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-207: Extend BufferAllocator interface to allow decorators around BufferAllocator #81
Conversation
…d BufferAllocator Currently AllocationManager needs BufferAllocator instance reference for accounting purposes. Having a decorator around the BufferAllocator distrubs the accounting in AllocationManager. Add an unwrap method to allow getting the reference to inner BufferAllocator instance and use this method in AllocationManager to get the actual BufferAllocator. /** * Unwrap the class so that exposes the provided interface, if possible. Otherwise, throw Exception. * @param c * The class or interface that you want this class to implement/extend. * @return The instance of that class related to 'this' */ <T> T unwrap(Class<T> c);
If AllocationManager assumes the the BufferAllocator is a specific implementation class, what is the point of the interface? It seems to me we should either fix the interface or get rid of it. |
I agree, current AllocationManager depends on the implementation of BufferAllocator, BaseAllocator, than the interface. |
I suggest we abandon this and come up with a different approach for the extensibility you're trying to achieve. |
1. Added lock to holder read to address potential race condition. 2. Fixed log message. 3, Addressed breaking arrow change.
1. Added lock to holder read to address potential race condition. 2. Fixed log message. 3, Addressed breaking arrow change.
1. Added lock to holder read to address potential race condition. 2. Fixed log message. 3, Addressed breaking arrow change.
1. Added lock to holder read to address potential race condition. 2. Fixed log message. 3, Addressed breaking arrow change.
Author: Aliaksei Sandryhaila <aliaksei.sandryhaila@hp.com> Closes apache#81 from asandryh/PARQUET-568 and squashes the following commits: f619ed0 [Aliaksei Sandryhaila] Addressed PR comments. bf12164 [Aliaksei Sandryhaila] Added column selection capability to parquet_reader.
1. Added lock to holder read to address potential race condition. 2. Fixed log message. 3, Addressed breaking arrow change.
Author: Aliaksei Sandryhaila <aliaksei.sandryhaila@hp.com> Closes apache#81 from asandryh/PARQUET-568 and squashes the following commits: f619ed0 [Aliaksei Sandryhaila] Addressed PR comments. bf12164 [Aliaksei Sandryhaila] Added column selection capability to parquet_reader. Change-Id: I5cb658f51e9f761e83be22424f2f36593a169766
Author: Aliaksei Sandryhaila <aliaksei.sandryhaila@hp.com> Closes apache#81 from asandryh/PARQUET-568 and squashes the following commits: f619ed0 [Aliaksei Sandryhaila] Addressed PR comments. bf12164 [Aliaksei Sandryhaila] Added column selection capability to parquet_reader. Change-Id: I5cb658f51e9f761e83be22424f2f36593a169766
Author: Aliaksei Sandryhaila <aliaksei.sandryhaila@hp.com> Closes apache#81 from asandryh/PARQUET-568 and squashes the following commits: f619ed0 [Aliaksei Sandryhaila] Addressed PR comments. bf12164 [Aliaksei Sandryhaila] Added column selection capability to parquet_reader. Change-Id: I5cb658f51e9f761e83be22424f2f36593a169766
Author: Aliaksei Sandryhaila <aliaksei.sandryhaila@hp.com> Closes apache#81 from asandryh/PARQUET-568 and squashes the following commits: f619ed0 [Aliaksei Sandryhaila] Addressed PR comments. bf12164 [Aliaksei Sandryhaila] Added column selection capability to parquet_reader. Change-Id: I5cb658f51e9f761e83be22424f2f36593a169766
1. Added lock to holder read to address potential race condition. 2. Fixed log message. 3, Addressed breaking arrow change.
1. Added lock to holder read to address potential race condition. 2. Fixed log message. 3, Addressed breaking arrow change.
* remove numa, vmemcache dependency * remove properties test
Currently AllocationManager needs BufferAllocator instance reference for accounting purposes.
Having a decorator around the BufferAllocator disturbs the accounting in AllocationManager.
Add an unwrap method to allow getting the reference to inner BufferAllocator instance and use
this method in AllocationManager to get the actual BufferAllocator.
/**
*/
T unwrap(Class c);
@StevenMPhillips: Could you please review this patch?